Skip to content

Commit 1233e1b

Browse files
committed
Override testViewUnique where not supported
1 parent 0719868 commit 1233e1b

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/nessie/TestTrinoNessieCatalog.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,14 @@ public void testView()
160160
.hasMessageContaining("createView is not supported for Iceberg Nessie catalogs");
161161
}
162162

163+
@Test
164+
@Override
165+
public void testViewUnique()
166+
{
167+
assertThatThrownBy(super::testView)
168+
.hasMessageContaining("createView is not supported for Iceberg Nessie catalogs");
169+
}
170+
163171
@Test
164172
@Override
165173
public void testNonLowercaseNamespace()

plugin/trino-iceberg/src/test/java/org/apache/iceberg/snowflake/TestTrinoSnowflakeCatalog.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,26 @@ public void testView()
349349
.hasMessageContaining("Views are not supported for the Snowflake Iceberg catalog");
350350
}
351351

352+
// Overridden to assert correct method calls as the tested feature is not supported
353+
@Test
354+
@Override
355+
public void testViewUnique()
356+
{
357+
ConnectorViewDefinition viewDefinition = new ConnectorViewDefinition(
358+
"SELECT name FROM local.tiny.%s".formatted(TpchTable.NATION.getTableName()),
359+
Optional.empty(),
360+
Optional.empty(),
361+
ImmutableList.of(
362+
new ConnectorViewDefinition.ViewColumn("name", VarcharType.createVarcharType(25).getTypeId(), Optional.empty())),
363+
Optional.empty(),
364+
Optional.of(SESSION.getUser()),
365+
false,
366+
ImmutableList.of());
367+
TrinoCatalog catalog = createTrinoCatalog(true);
368+
assertThatThrownBy(() -> catalog.createView(SESSION, SchemaTableName.schemaTableName(SNOWFLAKE_TEST_SCHEMA, TpchTable.NATION.getTableName()), viewDefinition, true))
369+
.hasMessageContaining("Views are not supported for the Snowflake Iceberg catalog");
370+
}
371+
352372
@Test
353373
@Override
354374
public void testListTables()

0 commit comments

Comments
 (0)