Skip to content

Commit be991cc

Browse files
committed
Move assertions in BaseSqlServerConnectorTest
1 parent c45c360 commit be991cc

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

plugin/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/BaseSqlServerConnectorTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,15 @@ public void testPredicatePushdown()
223223
.returnsEmptyResult()
224224
.isFullyPushedDown();
225225

226+
// varchar predicate over join
227+
Session joinPushdownEnabled = joinPushdownEnabled(getSession());
228+
assertThat(query(joinPushdownEnabled, "SELECT c.name, n.name FROM customer c JOIN nation n ON c.custkey = n.nationkey WHERE n.name = 'POLAND'"))
229+
.isFullyPushedDown();
230+
231+
// join on varchar columns
232+
assertThat(query(joinPushdownEnabled, "SELECT n.name, n2.regionkey FROM nation n JOIN nation n2 ON n.name = n2.name"))
233+
.isFullyPushedDown();
234+
226235
// bigint equality
227236
assertThat(query("SELECT regionkey, nationkey, name FROM nation WHERE nationkey = 19"))
228237
.matches("VALUES (BIGINT '3', BIGINT '19', CAST('ROMANIA' AS varchar(25)))")
@@ -286,15 +295,6 @@ public void testPredicatePushdown()
286295
assertThat(query("SELECT * FROM " + testTable.getName() + " WHERE long_decimal = 123456789.987654321"))
287296
.matches("VALUES (CAST(123.321 AS decimal(9,3)), CAST(123456789.987654321 AS decimal(30, 10)))")
288297
.isFullyPushedDown();
289-
290-
// varchar predicate over join
291-
Session joinPushdownEnabled = joinPushdownEnabled(getSession());
292-
assertThat(query(joinPushdownEnabled, "SELECT c.name, n.name FROM customer c JOIN nation n ON c.custkey = n.nationkey WHERE n.name = 'POLAND'"))
293-
.isFullyPushedDown();
294-
295-
// join on varchar columns
296-
assertThat(query(joinPushdownEnabled, "SELECT n.name, n2.regionkey FROM nation n JOIN nation n2 ON n.name = n2.name"))
297-
.isFullyPushedDown();
298298
}
299299
}
300300

0 commit comments

Comments
 (0)