fix(vm): regex parsing (#794)

Co-authored-by: Aapo Alasuutari <[email protected]>

Author: DonIsaac

nova_vm/src/ecmascript/builtins/regexp/abstract_operations.rs

@@ -6,7 +6,7 @@ use std::ops::ControlFlow;
 
 use oxc_allocator::Allocator;
 use oxc_ast::ast::RegExpFlags;
-use oxc_regular_expression::ConstructorParser;
+use oxc_regular_expression::{LiteralParser, Options};
 
 use crate::{
     ecmascript::{
@@ -196,13 +196,19 @@ pub(crate) fn reg_exp_initialize<'a>(
         Ok(f) => f.as_str().into(),
         Err(f) => f.to_string_lossy(agent),
     };
+    let flags: Option<&str> = if f_str.is_empty() {
+        None
+    } else {
+        Some(f_str.as_ref())
+    };
+
     let allocator = Allocator::new();
     // 13. Let parseResult be ParsePattern(patternText, u, v).
-    match ConstructorParser::new(
+    match LiteralParser::new(
         &allocator,
         &p.to_string_lossy(agent),
-        Some(&f_str),
-        Default::default(),
+        flags,
+        Options::default(),
     )
     .parse()
     {
@@ -241,22 +247,25 @@ fn parse_flags(f: &str) -> Option<RegExpFlags> {
     let mut flags: u8 = 0;
     for cu in f.as_bytes() {
         match cu {
+            b'd' => flags |= RegExpFlags::D.bits(),
+            b'g' => flags |= RegExpFlags::G.bits(),
             // 6. If F contains "i", let i be true; else let i be false.
-            b'i' => flags &= RegExpFlags::I.bits(),
+            b'i' => flags |= RegExpFlags::I.bits(),
             // 7. If F contains "m", let m be true; else let m be false.
-            b'm' => flags &= RegExpFlags::M.bits(),
+            b'm' => flags |= RegExpFlags::M.bits(),
             // 8. If F contains "s", let s be true; else let s be false.
-            b's' => flags &= RegExpFlags::S.bits(),
+            b's' => flags |= RegExpFlags::S.bits(),
             // 9. If F contains "u", let u be true; else let u be false.
-            b'u' => flags &= RegExpFlags::U.bits(),
+            b'u' => flags |= RegExpFlags::U.bits(),
             // 10. If F contains "v", let v be true; else let v be false.
-            b'v' => flags &= RegExpFlags::V.bits(),
+            b'v' => flags |= RegExpFlags::V.bits(),
+            b'y' => flags |= RegExpFlags::Y.bits(),
+            // 5. If F contains any code unit other than "d", "g", "i", "m",
+            //    "s", "u", "v", or "y", or if F contains any code unit more
+            //    than once, throw a SyntaxError exception.
             _ => return None,
         }
     }
-    // 5. If F contains any code unit other than "d", "g", "i", "m", "s", "u",
-    //    "v", or "y", or if F contains any code unit more than once, throw a
-    //    SyntaxError exception.
     Some(RegExpFlags::from_bits_retain(flags))
 }