Does nova consider supporting v8-v7 test?

[ahaoboy]

https://github.com/mozilla/arewefastyet/tree/master/benchmarks/v8-v7

https://github.com/mozilla/arewefastyet/tree/master/benchmarks/v8-v7

js-engine-benchmark tests many engines, nova cannot pass the test yet

 C:/Users/Admin/Downloads/nova-windows-amd64.exe eval  ./dist/run.js
Richards: 47.4
DeltaBlue: 54.4
Uncaught exception: TypeError: Not a callable object

run.zip

[aapoalas]

Hey, thanks for the issue!

The aim absolutely is to support (roughly) all JavaScript. The "Not a callable object" error sounds like this might be about callable Proxies, which are a right pain but nothing too impossible or complicated to support. The issue mainly is that we currently return an Option<Function> from our is_callable method when we should rather return an Option<Callable>; just that "Callable" doesn't exist yet.

[aapoalas]

I looked into this a bit more, and the errors appear in regexp.js and splay.js. In both cases it's about effectively doing undefined(param), ie. trying to call an undefined value. So it's not about callable Proxies at all. Probably for the RegExp case it's about lack of some RegExp methods being supported, perhaps? But the splay.js case is a lot more interesting: for one, that test contains no RegExp. Second; the error disappears if I use the --verbose flag to log what the runtime is doing. This points to a GC problem.

[ahaoboy]

boa uses https://github.com/ridiculousfish/regress to process regular expressions, which can pass v8-v7 regular expression test

[aapoalas]

I'm not sure but I expect that the library we use, regex, can likewise handle the regular expressions in regexp.js, it's just that I've not yet implemented all the binding methods, such as RegExp.prototype.match.

[ahaoboy]

This test also requires a larger stack size because there are some recursive tests. nginx/njs#940