Skip to content

Add dashboard UI tests to PR CI workflow #977

@e-gineer

Description

@e-gineer

Problem

Dashboard UI tests (yarn test) are currently only run during the release workflow, not on pull requests. This means UI regressions and test failures won't be caught until release time.

Current State

PR CI workflows run:

  • ✅ Go linting (golangci-lint)
  • ✅ Go acceptance tests
  • ✅ Build validation
  • ❌ Dashboard UI tests (yarn test)

Proposed Solution

Add a step to run dashboard UI tests in the PR CI workflow (likely in 11-test-acceptance.yaml or a new workflow).

This would:

  1. Catch UI regressions earlier in the development cycle
  2. Validate that dashboard tests pass before merging
  3. Provide faster feedback to contributors
  4. Align with test-driven development practices

Example

In PR #975, commit 1 adds a test that fails locally, but CI shows green because dashboard tests aren't run. This masks the test failure until someone manually runs yarn test.

Implementation

Could add a job like:

dashboard-tests:
  name: Dashboard UI Tests
  runs-on: ubuntu-latest
  steps:
    - uses: actions/checkout@v5
    - uses: actions/setup-node@v4
      with:
        node-version: '20'
    - run: corepack enable
    - name: Install dependencies
      run: cd ui/dashboard && yarn install
    - name: Run tests
      run: cd ui/dashboard && yarn test --watchAll=false

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions