-
Notifications
You must be signed in to change notification settings - Fork 43
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Problem
Dashboard UI tests (yarn test) are currently only run during the release workflow, not on pull requests. This means UI regressions and test failures won't be caught until release time.
Current State
PR CI workflows run:
- ✅ Go linting (
golangci-lint) - ✅ Go acceptance tests
- ✅ Build validation
- ❌ Dashboard UI tests (
yarn test)
Proposed Solution
Add a step to run dashboard UI tests in the PR CI workflow (likely in 11-test-acceptance.yaml or a new workflow).
This would:
- Catch UI regressions earlier in the development cycle
- Validate that dashboard tests pass before merging
- Provide faster feedback to contributors
- Align with test-driven development practices
Example
In PR #975, commit 1 adds a test that fails locally, but CI shows green because dashboard tests aren't run. This masks the test failure until someone manually runs yarn test.
Implementation
Could add a job like:
dashboard-tests:
name: Dashboard UI Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: '20'
- run: corepack enable
- name: Install dependencies
run: cd ui/dashboard && yarn install
- name: Run tests
run: cd ui/dashboard && yarn test --watchAll=falseRelated
- PR Edge titles on collapsed nodes closes #973 #975 (edge titles bug fix) where this gap was discovered
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request