Overriding Meta throws a false alarm in pyright if the parent class defines it too

[Diegovsky]

Bug report

Say I have the following class:

class BaseModel(models.Model):
    created_at = models.DateTimeField( auto_now_add=True)
    updated_at = models.DateTimeField(auto_now=True)

    class Meta:
        abstract = True
        ordering = ["-created_at"]

Inheriting from this base class results in an "Meta" overrides symbol of the same name in class "BaseModel" error.

Workaround

Making Meta inherit from BaseModel.Meta works, but I think this is not very idiomatic, and also makes it compulsory to set abstract = False in all subclasses.

System information

• OS:
• python version: 3.12
• django version: 5.2.3
• pyright : 1.1.402
• django-stubs version: 5.2.1
• django-stubs-ext version: 5.2.1

[sobolevn]

Fixes are welcome!

[Diegovsky]

I would submit a PR but I don't understand the python typing annotation system enough. I tried adding Meta: ClassVar[Any] to my superclass but it really didn't do anything.

If anyone has any pointers, I would gladly submit a pull request.

[UnknownPlatypus]

Not sure we can do much here, we are not declaring the type of the Meta class in the stubs so your issue is self contained I think.

Seem to be related to pyright design decisions around overriding classvars.
Given this snippet:

class BaseModel:
   class Meta:
       abstract = True
       ordering = ["-created_at"]

class MyModel(BaseModel):
   class Meta:
       ordering = ["-id"]

mypy in strict mode with no django plugin is ok with that - ty too.
But pyright is not

[Diegovsky]

oof

hoping ty improves so I can move off pyright