Skip to content

Conversation

@iRevive
Copy link
Contributor

@iRevive iRevive commented Apr 10, 2025

No description provided.

@iRevive iRevive changed the title Update Scala Native to 0.5.6 Update Scala Native to 0.5.8 Jul 31, 2025
@iRevive iRevive marked this pull request as ready for review July 31, 2025 05:46
@iRevive
Copy link
Contributor Author

iRevive commented Jul 31, 2025

MiMA errors are unclear to me:

[error] munit-cats-effect: Failed binary compatibility check against org.typelevel:munit-cats-effect_3:2.1.0 (e:info.apiURL=https://javadoc.invalid/doc/org.typelevel/munit-cats-effect_3/2.2-b8cc499-SNAPSHOT/, e:info.versionScheme=early-semver)! Found 6 potential problems
[error]  * static method assertEquals(java.lang.Object,java.lang.Object,scala.Function0,munit.Location,munit.Compare)Unit in interface munit.CatsEffectAssertions does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("munit.CatsEffectAssertions.assertEquals")
[error]  * static method assertNoDiff(java.lang.String,java.lang.String,scala.Function0,munit.Location)Unit in interface munit.CatsEffectAssertions does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("munit.CatsEffectAssertions.assertNoDiff")
[error]  * static method fail(java.lang.String,munit.Clues,munit.Location)scala.runtime.Nothing# in interface munit.CatsEffectAssertions does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("munit.CatsEffectAssertions.fail")
[error]  * static method fail(java.lang.String,java.lang.Throwable,munit.Location)scala.runtime.Nothing# in interface munit.CatsEffectAssertions does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("munit.CatsEffectAssertions.fail")
[error]  * static method failComparison(java.lang.String,java.lang.Object,java.lang.Object,munit.Clues,munit.Location)scala.runtime.Nothing# in interface munit.CatsEffectAssertions does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("munit.CatsEffectAssertions.failComparison")
[error]  * static method failSuite(java.lang.String,munit.Clues,munit.Location)scala.runtime.Nothing# in interface munit.CatsEffectAssertions does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("munit.CatsEffectAssertions.failSuite")
[error] java.lang.RuntimeException: Failed binary compatibility check against org.typelevel:munit-cats-effect_3:2.1.0 (e:info.apiURL=https://javadoc.invalid/doc/org.typelevel/munit-cats-effect_3/2.2-b8cc499-SNAPSHOT/, e:info.versionScheme=early-semver)! Found 6 potential problems

build.sbt Outdated
libraryDependencies ++= Seq(
"org.scalameta" %%% "munit" % "1.0.0",
"org.typelevel" %%% "cats-effect" % "3.6.3"
"org.scalameta" %%% "munit" % "1.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is 1.1.1 not sure hwy there are no Steward PR for this dependency
https://github.com/scalameta/munit/releases/tag/v1.1.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@armanbilge
Copy link
Member

Those MiMa errors are weird. I wonder if MUnit made some backwards-incompatible changes 🤔 and we used to inherit those methods, but they are now gone?

@iRevive iRevive requested a review from mzuehlke July 31, 2025 17:59
@iRevive
Copy link
Contributor Author

iRevive commented Jul 31, 2025

Those MiMa errors are weird. I wonder if MUnit made some backwards-incompatible changes 🤔 and we used to inherit those methods, but they are now gone?

You were right, that was the reason behind these MiMa errors.

Copy link
Contributor

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@mpilquist mpilquist merged commit 4b1e787 into typelevel:main Aug 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants