Review Feedback Vol. 1

Author: Vampire

maven-binding-builder/src/test/kotlin/io/github/typesafegithub/workflows/mavenbinding/MavenMetadataBuildingTest.kt

@@ -1,6 +1,8 @@
 package io.github.typesafegithub.workflows.mavenbinding
 
 import io.github.typesafegithub.workflows.actionbindinggenerator.domain.ActionCoords
+import io.github.typesafegithub.workflows.actionbindinggenerator.domain.SignificantVersion
+import io.github.typesafegithub.workflows.actionbindinggenerator.domain.SignificantVersion.FULL
 import io.github.typesafegithub.workflows.shared.internal.model.Version
 import io.kotest.core.spec.style.FunSpec
 import io.kotest.matchers.nulls.shouldBeNull
@@ -91,4 +93,52 @@ class MavenMetadataBuildingTest :
 
             xml.shouldBeNull()
         }
+
+        (SignificantVersion.entries - FULL).forEach { significantVersion ->
+            test("significant version $significantVersion requested") {
+                // Given
+                val fetchAvailableVersions: suspend (String, String, String?) -> List<Version> = { owner, name, _ ->
+                    listOf(
+                        Version(version = "v3-beta", dateProvider = { ZonedDateTime.parse("2024-07-01T00:00:00Z") }),
+                        Version(version = "v2", dateProvider = { ZonedDateTime.parse("2024-05-01T00:00:00Z") }),
+                        Version(version = "v1", dateProvider = { ZonedDateTime.parse("2024-03-07T00:00:00Z") }),
+                        Version(version = "v1.1", dateProvider = { ZonedDateTime.parse("2024-03-07T00:00:00Z") }),
+                        Version(version = "v1.1.0", dateProvider = { ZonedDateTime.parse("2024-03-07T00:00:00Z") }),
+                        Version(version = "v1.0.1", dateProvider = { ZonedDateTime.parse("2024-03-05T00:00:00Z") }),
+                        Version(version = "v1.0", dateProvider = { ZonedDateTime.parse("2024-03-01T00:00:00Z") }),
+                        Version(version = "v1.0.0", dateProvider = { ZonedDateTime.parse("2024-03-01T00:00:00Z") }),
+                    )
+                }
+
+                val xml =
+                    actionCoords.copy(significantVersion = significantVersion).buildMavenMetadataFile(
+                        githubToken = "SOME_TOKEN",
+                        fetchAvailableVersions = fetchAvailableVersions,
+                    )
+
+                xml shouldBe
+                    """
+                    <?xml version="1.0" encoding="UTF-8"?>
+                    <metadata>
+                      <groupId>owner</groupId>
+                      <artifactId>name___$significantVersion</artifactId>
+                      <versioning>
+                        <latest>v2</latest>
+                        <release>v2</release>
+                        <versions>
+                          <version>v3-beta</version>
+                          <version>v2</version>
+                          <version>v1</version>
+                          <version>v1.1</version>
+                          <version>v1.1.0</version>
+                          <version>v1.0.1</version>
+                          <version>v1.0</version>
+                          <version>v1.0.0</version>
+                        </versions>
+                        <lastUpdated>20240501000000</lastUpdated>
+                      </versioning>
+                    </metadata>
+                    """.trimIndent()
+            }
+        }
     })