Skip to content
This repository was archived by the owner on Aug 17, 2020. It is now read-only.

Commit 4b85f97

Browse files
committed
remove tracestate
1 parent 9af785f commit 4b85f97

File tree

1 file changed

+29
-47
lines changed

1 file changed

+29
-47
lines changed

tracer/propagation_ot.go

Lines changed: 29 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ const (
3030
fieldNameSampled = prefixTracerState + "sampled"
3131

3232
traceParentKey = "traceparent"
33-
traceStateKey = "tracestate"
3433
)
3534

3635
func (p *textMapPropagator) Inject(
@@ -64,16 +63,10 @@ func (p *textMapPropagator) Inject(
6463
)
6564
carrier.Set(traceParentKey, traceParentValue)
6665

67-
var traceStatePairs []string
68-
6966
for k, v := range sc.Baggage {
7067
carrier.Set(prefixBaggage+k, v)
71-
traceStatePairs = append(traceStatePairs, k+"="+v)
7268
}
7369

74-
traceStateValue := strings.Join(traceStatePairs, ",")
75-
carrier.Set(traceStateKey, traceStateValue)
76-
7770
return nil
7871
}
7972

@@ -113,55 +106,44 @@ func (p *textMapPropagator) Extract(
113106
if traceParentArray[3] == "01" {
114107
sampled = true
115108
}
116-
requiredFieldCount = requiredFieldCount + 2
117-
case traceStateKey:
118-
traceStateArray := strings.Split(v, ",")
119-
for _, stItem := range traceStateArray {
120-
stItem = strings.TrimSpace(stItem)
121-
if strings.IndexRune(stItem, '=') > -1 {
122-
stItemArray := strings.Split(stItem, "=")
123-
decodedBaggage[stItemArray[0]] = stItemArray[1]
124-
}
125-
}
109+
requiredFieldCount = requiredFieldCount + 3
126110
default:
127111
// Balance off the requiredFieldCount++ just below...
128112
requiredFieldCount--
129113
}
130114
requiredFieldCount++
131115
return nil
132116
})
133-
if traceID == uuid.Nil && spanID == 0 {
134-
err = carrier.ForeachKey(func(k, v string) error {
135-
switch strings.ToLower(k) {
136-
case fieldNameTraceID:
137-
traceID, err = uuid.Parse(v)
138-
if err != nil {
139-
return opentracing.ErrSpanContextCorrupted
140-
}
141-
case fieldNameSpanID:
142-
spanID, err = strconv.ParseUint(v, 16, 64)
143-
if err != nil {
144-
return opentracing.ErrSpanContextCorrupted
145-
}
146-
case fieldNameSampled:
147-
sampled, err = strconv.ParseBool(v)
148-
if err != nil {
149-
return opentracing.ErrSpanContextCorrupted
150-
}
151-
default:
152-
lowercaseK := strings.ToLower(k)
153-
if strings.HasPrefix(lowercaseK, prefixBaggage) {
154-
decodedBaggage[strings.TrimPrefix(lowercaseK, prefixBaggage)] = v
155-
}
156-
// Balance off the requiredFieldCount++ just below...
157-
requiredFieldCount--
117+
err = carrier.ForeachKey(func(k, v string) error {
118+
switch strings.ToLower(k) {
119+
case fieldNameTraceID:
120+
traceID, err = uuid.Parse(v)
121+
if err != nil {
122+
return opentracing.ErrSpanContextCorrupted
158123
}
159-
requiredFieldCount++
160-
return nil
161-
})
162-
if err != nil {
163-
return nil, err
124+
case fieldNameSpanID:
125+
spanID, err = strconv.ParseUint(v, 16, 64)
126+
if err != nil {
127+
return opentracing.ErrSpanContextCorrupted
128+
}
129+
case fieldNameSampled:
130+
sampled, err = strconv.ParseBool(v)
131+
if err != nil {
132+
return opentracing.ErrSpanContextCorrupted
133+
}
134+
default:
135+
lowercaseK := strings.ToLower(k)
136+
if strings.HasPrefix(lowercaseK, prefixBaggage) {
137+
decodedBaggage[strings.TrimPrefix(lowercaseK, prefixBaggage)] = v
138+
}
139+
// Balance off the requiredFieldCount++ just below...
140+
requiredFieldCount--
164141
}
142+
requiredFieldCount++
143+
return nil
144+
})
145+
if err != nil {
146+
return nil, err
165147
}
166148

167149
if requiredFieldCount < tracerStateFieldCount {

0 commit comments

Comments
 (0)