fix: Handle optional receiverCounterparty field on AccountLowBalanceClosureTransaction resource (#290)

* fix: Handle accountLowBalanceClosureTransaction's optional receiverCounterparty field

* tests: Add accountLowBalanceClosureTransaction decoding tests

---------

Co-authored-by: Henrique Salvaro <[email protected]>

Author: YegorZh

e2e_tests/transaction_test.py

@@ -1,4 +1,7 @@
 import os
+
+import pytest
+
 from unit import Unit
 from unit.models.transaction import *
 from unit.models.codecs import DtoDecoder, mappings
@@ -690,3 +693,75 @@ def test_wire_transaction():
     assert transaction.attributes["balance"] == wire_transaction_api_response.get("attributes").get("balance")
     assert transaction.attributes["summary"] == wire_transaction_api_response.get("attributes").get("summary")
 
+
+@pytest.mark.parametrize("include_counterparty", [True, False])
+def test_account_low_balance_closure_transaction(include_counterparty):
+    account_low_balance_closure_transaction_response = {
+        "type": "accountLowBalanceClosureTransaction",
+        "id": "53",
+        "attributes": {
+            "createdAt": "2022-04-06T10:46:34.371Z",
+            "amount": 800,
+            "direction": "Credit",
+            "balance": 113000,
+            "summary": "Account Low Balance Closure",
+            "tags": {
+                "customer_type": "vip"
+            }
+        },
+        "relationships": {
+            "account": {
+                "data": {
+                    "type": "account",
+                    "id": "10001"
+                }
+            },
+            "customer": {
+                "data": {
+                    "type": "customer",
+                    "id": "10000"
+                }
+            },
+            "customers": {
+                "data": [
+                    {
+                        "type": "customer",
+                        "id": "10000"
+                    }
+                ]
+            },
+            "org": {
+                "data": {
+                    "type": "org",
+                    "id": "1"
+                }
+            },
+            "receiverAccount": {
+                "data": {
+                    "type": "account",
+                    "id": "10000"
+                }
+            }
+        }
+    }
+    if include_counterparty:
+        account_low_balance_closure_transaction_response["attributes"]["receiverCounterparty"] = {
+            "name": "Unit Finance Inc.",
+            "routingNumber": "091311229",
+            "accountNumber": "864800000000",
+            "accountType": "Checking"
+        }
+
+    transaction = DtoDecoder.decode(account_low_balance_closure_transaction_response)
+
+    assert transaction.id == "53"
+    assert transaction.type == "accountLowBalanceClosureTransaction"
+    assert transaction.attributes["amount"] == 800
+    assert transaction.attributes["direction"] == "Credit"
+    assert transaction.attributes["balance"] == 113000
+    assert transaction.attributes["summary"] == "Account Low Balance Closure"
+
+    if include_counterparty:
+        assert transaction.attributes["receiverCounterparty"].routing_number == "091311229"
+    else:
+        assert "receiverCounterparty" not in transaction.attributes

unit/models/transaction.py

@@ -457,19 +457,22 @@ def from_json_api(_id, _type, attributes, relationships):
 
 class AccountLowBalanceClosureTransactionDTO(BaseTransactionDTO):
     def __init__(self, id: str, created_at: datetime, direction: str, amount: int, balance: int, summary: str,
-                 receiver_counterparty: Counterparty, tags: Optional[Dict[str, str]],
+                 receiver_counterparty: Optional[Counterparty], tags: Optional[Dict[str, str]],
                  relationships: Optional[Dict[str, Relationship]]):
         BaseTransactionDTO.__init__(self, id, created_at, direction, amount, balance, summary, tags, relationships)
         self.type = 'accountLowBalanceClosureTransaction'
-        self.attributes["receiverCounterparty"] = receiver_counterparty
+        if receiver_counterparty:
+            self.attributes["receiverCounterparty"] = receiver_counterparty
 
     @staticmethod
     def from_json_api(_id, _type, attributes, relationships):
+        counterparty = None
+        if attributes.get("receiverCounterparty"):
+            counterparty = Counterparty.from_json_api(attributes.get("receiverCounterparty"))
         return AccountLowBalanceClosureTransactionDTO(_id, date_utils.to_datetime(attributes["createdAt"]),
                                                    attributes["direction"], attributes["amount"], attributes["balance"],
-                                                   attributes["summary"],
-                                                   Counterparty.from_json_api(attributes.get("receiverCounterparty")),
-                                                   attributes.get("tags"), relationships)
+                                                   attributes["summary"], counterparty, attributes.get("tags"),
+                                                   relationships)
 
 
 class NegativeBalanceCoverageTransactionDTO(BaseTransactionDTO):