From 5bd2ff76834fd6285522734f4bd62d7a7267d0e6 Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Mon, 13 Oct 2025 16:30:39 +0400 Subject: [PATCH 1/6] refactor: increase min-height for grid rows in base styles --- packages/grid/src/styles/vaadin-grid-base-styles.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/grid/src/styles/vaadin-grid-base-styles.js b/packages/grid/src/styles/vaadin-grid-base-styles.js index d521e959cb..dc56fbe3c2 100644 --- a/packages/grid/src/styles/vaadin-grid-base-styles.js +++ b/packages/grid/src/styles/vaadin-grid-base-styles.js @@ -127,7 +127,7 @@ export const gridStyles = css` [part~='reorder-ghost'] { font-size: var(--vaadin-grid-header-font-size, 1em); font-weight: var(--vaadin-grid-header-font-weight, 500); - color: var(--vaadin-grid-header-text-color, var(--vaadin-text-color)); + color: var(--vaadin-grid-header-color, var(--vaadin-text-color)); } [part~='row'] { @@ -337,6 +337,7 @@ export const gridStyles = css` text-overflow: ellipsis; padding: var(--vaadin-grid-cell-padding, var(--vaadin-padding-container)); flex: 1; + min-height: 1lh; min-width: 0; } From 27d0e17560fbc840dc163c0b7e255cff39cbb91b Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Mon, 13 Oct 2025 19:32:28 +0400 Subject: [PATCH 2/6] Update packages/grid/src/styles/vaadin-grid-base-styles.js --- packages/grid/src/styles/vaadin-grid-base-styles.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/grid/src/styles/vaadin-grid-base-styles.js b/packages/grid/src/styles/vaadin-grid-base-styles.js index dc56fbe3c2..097e0858e9 100644 --- a/packages/grid/src/styles/vaadin-grid-base-styles.js +++ b/packages/grid/src/styles/vaadin-grid-base-styles.js @@ -127,7 +127,7 @@ export const gridStyles = css` [part~='reorder-ghost'] { font-size: var(--vaadin-grid-header-font-size, 1em); font-weight: var(--vaadin-grid-header-font-weight, 500); - color: var(--vaadin-grid-header-color, var(--vaadin-text-color)); + color: var(--vaadin-grid-header-text-color, var(--vaadin-text-color)); } [part~='row'] { From ab6a7b4f12a70afc16410d0cec0e8143b44f1e64 Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Tue, 14 Oct 2025 18:11:25 +0400 Subject: [PATCH 3/6] disable negative margins to avoid rows under header being considered visible --- packages/grid/src/styles/vaadin-grid-base-styles.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/grid/src/styles/vaadin-grid-base-styles.js b/packages/grid/src/styles/vaadin-grid-base-styles.js index 097e0858e9..6eec29f823 100644 --- a/packages/grid/src/styles/vaadin-grid-base-styles.js +++ b/packages/grid/src/styles/vaadin-grid-base-styles.js @@ -159,7 +159,7 @@ export const gridStyles = css` box-sizing: border-box; background: var(--vaadin-grid-cell-background, var(--vaadin-background-color)); border-block: var(--_row-border-width) solid var(--_border-color); - margin-top: calc(var(--_row-border-width) * -1); + /* margin-top: calc(var(--_row-border-width) * -1); */ /* Box-shadows are used to create a "fake" border at the end of the cell/row, which is visible when a row/cell ends @@ -368,7 +368,7 @@ export const gridStyles = css` inset: 0; flex: 1; overflow: hidden; - margin-top: calc(var(--_row-border-width) * -1); + /* margin-top: calc(var(--_row-border-width) * -1); */ } #emptystaterow { From 9b32469b9788e08b5507626eac11639209beacb5 Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Wed, 15 Oct 2025 13:14:50 +0400 Subject: [PATCH 4/6] wip --- packages/grid/src/styles/vaadin-grid-base-styles.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/grid/src/styles/vaadin-grid-base-styles.js b/packages/grid/src/styles/vaadin-grid-base-styles.js index 6eec29f823..4d65ee1ee2 100644 --- a/packages/grid/src/styles/vaadin-grid-base-styles.js +++ b/packages/grid/src/styles/vaadin-grid-base-styles.js @@ -22,7 +22,7 @@ export const gridStyles = css` cursor: default; --_border-color: var(--vaadin-grid-border-color, var(--vaadin-border-color-secondary)); --_border-width: 0; - --_row-border-width: var(--vaadin-grid-row-border-width, 1px); + --_row-border-width: var(--vaadin-grid-row-border-width, 5px); --_column-border-width: var(--vaadin-grid-column-border-width, 0px); border-radius: var(--_border-radius); --_border-radius: 0; @@ -159,7 +159,7 @@ export const gridStyles = css` box-sizing: border-box; background: var(--vaadin-grid-cell-background, var(--vaadin-background-color)); border-block: var(--_row-border-width) solid var(--_border-color); - /* margin-top: calc(var(--_row-border-width) * -1); */ + margin-top: calc(var(--_row-border-width) * -1); /* Box-shadows are used to create a "fake" border at the end of the cell/row, which is visible when a row/cell ends @@ -368,7 +368,7 @@ export const gridStyles = css` inset: 0; flex: 1; overflow: hidden; - /* margin-top: calc(var(--_row-border-width) * -1); */ + margin-top: calc(var(--_row-border-width) * -1); } #emptystaterow { From de73180799a206ed5aae342acfc3cd96159c564b Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Thu, 16 Oct 2025 10:36:53 +0400 Subject: [PATCH 5/6] wip --- packages/grid/src/styles/vaadin-grid-base-styles.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/grid/src/styles/vaadin-grid-base-styles.js b/packages/grid/src/styles/vaadin-grid-base-styles.js index 4d65ee1ee2..097e0858e9 100644 --- a/packages/grid/src/styles/vaadin-grid-base-styles.js +++ b/packages/grid/src/styles/vaadin-grid-base-styles.js @@ -22,7 +22,7 @@ export const gridStyles = css` cursor: default; --_border-color: var(--vaadin-grid-border-color, var(--vaadin-border-color-secondary)); --_border-width: 0; - --_row-border-width: var(--vaadin-grid-row-border-width, 5px); + --_row-border-width: var(--vaadin-grid-row-border-width, 1px); --_column-border-width: var(--vaadin-grid-column-border-width, 0px); border-radius: var(--_border-radius); --_border-radius: 0; From b28509e9761a2277e18315d3c9a53a865ad73b26 Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Mon, 27 Oct 2025 12:27:44 +0400 Subject: [PATCH 6/6] disable grid borders in crud test --- packages/crud/test/a11y.test.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/crud/test/a11y.test.js b/packages/crud/test/a11y.test.js index e2552621f0..c61b16ac41 100644 --- a/packages/crud/test/a11y.test.js +++ b/packages/crud/test/a11y.test.js @@ -13,6 +13,16 @@ describe('a11y', () => { await setViewport({ width: 1024, height: 768 }); }); + beforeEach(() => { + fixtureSync(` + + `); + }); + function focusRestorationTests(testId, createFixture) { describe(`focus restoration - ${testId}`, () => { let grid, form, dialog, newButton, saveButton, cancelButton, editButtons;