chore(dev): upgrade to Rust 2024 edition (#23522)

* chore(dev): upgrade to Rust 2024 edition

* cargo clippy --fix

* bump to 2024

* fixes and updates

* cargo fmt --all

* fmt

* more fixes

* more fixes

* Update src/sinks/socket.rs

Co-authored-by: Thomas <[email protected]>

* ran cargo fmt

* change edition in rustfmt

* ran cargo fmt

* ran cargo fmt

* address reporter future return type clippy failure

* ran cargo fmt

* events check

* ran cargo fmt

* running.rs changes

* upgrade cargo-deb

* ran cargo fmt

* fix

* ran cargo fmt

* cargo-deb override

* older cargo-deb

* downgrade cargo-deb

* fix one windows failure

* fix windows error[E0521]

---------

Co-authored-by: Thomas <[email protected]>

Author: pront

.rustfmt.toml

@@ -1,4 +1,4 @@
-edition = "2021"
+edition = "2024"
 newline_style = "unix"
 reorder_imports = true
 

Cargo.toml

@@ -2,7 +2,7 @@
 name = "vector"
 version = "0.50.0"
 authors = ["Vector Contributors <[email protected]>"]
-edition = "2021"
+edition = "2024"
 description = "A lightweight and ultra-fast tool for building observability pipelines"
 homepage = "https://vector.dev"
 license = "MPL-2.0"

aqua/aqua.yaml

@@ -6,7 +6,7 @@ registries:
     ref: v4.268.0 # renovate: depName=aquaproj/aqua-registry
 packages:
   - name: rustwasm/[email protected]
-  - name: crates.io/cargo-deb@3.4.1
+  - name: crates.io/cargo-deb@2.9.3
   - name: cross-rs/[email protected]
   - name: nextest-rs/nextest/[email protected]
   - name: EmbarkStudios/[email protected]

benches/batch.rs

@@ -1,13 +1,13 @@
 use std::{convert::Infallible, time::Duration};
 
 use bytes::{BufMut, Bytes, BytesMut};
-use criterion::{criterion_group, Criterion, SamplingMode, Throughput};
-use futures::{future, stream, SinkExt, StreamExt};
+use criterion::{Criterion, SamplingMode, Throughput, criterion_group};
+use futures::{SinkExt, StreamExt, future, stream};
 use vector::{
     sinks::util::{
-        batch::{Batch, BatchConfig, BatchError, BatchSettings, BatchSize, PushResult},
         BatchSink, Buffer, Compression, EncodedEvent, Merged, Partition, PartitionBatchSink,
         SinkBatchSettings,
+        batch::{Batch, BatchConfig, BatchError, BatchSettings, BatchSize, PushResult},
     },
     test_util::{random_lines, runtime},
 };

benches/codecs/character_delimited_bytes.rs

@@ -2,13 +2,13 @@ use std::{fmt, time::Duration};
 
 use bytes::BytesMut;
 use criterion::{
-    criterion_group, measurement::WallTime, BatchSize, BenchmarkGroup, BenchmarkId, Criterion,
-    SamplingMode, Throughput,
+    BatchSize, BenchmarkGroup, BenchmarkId, Criterion, SamplingMode, Throughput, criterion_group,
+    measurement::WallTime,
 };
 use tokio_util::codec::Decoder;
 use vector_lib::codecs::{
-    decoding::{Deserializer, Framer},
     BytesDeserializer, CharacterDelimitedDecoder,
+    decoding::{Deserializer, Framer},
 };
 
 #[derive(Debug)]

benches/codecs/encoder.rs

@@ -2,12 +2,12 @@ use std::time::Duration;
 
 use bytes::{BufMut, BytesMut};
 use criterion::{
-    criterion_group, measurement::WallTime, BatchSize, BenchmarkGroup, Criterion, SamplingMode,
-    Throughput,
+    BatchSize, BenchmarkGroup, Criterion, SamplingMode, Throughput, criterion_group,
+    measurement::WallTime,
 };
 use tokio_util::codec::Encoder;
 use vector::event::{Event, LogEvent};
-use vector_lib::codecs::{encoding::Framer, JsonSerializerConfig, NewlineDelimitedEncoder};
+use vector_lib::codecs::{JsonSerializerConfig, NewlineDelimitedEncoder, encoding::Framer};
 use vector_lib::{btreemap, byte_size_of::ByteSizeOf};
 
 #[derive(Debug, Clone)]

benches/codecs/newline_bytes.rs

@@ -2,12 +2,12 @@ use std::{fmt, time::Duration};
 
 use bytes::BytesMut;
 use criterion::{
-    criterion_group, measurement::WallTime, BatchSize, BenchmarkGroup, BenchmarkId, Criterion,
-    SamplingMode, Throughput,
+    BatchSize, BenchmarkGroup, BenchmarkId, Criterion, SamplingMode, Throughput, criterion_group,
+    measurement::WallTime,
 };
 use tokio_util::codec::Decoder;
 use vector_lib::codecs::{
-    decoding::Deserializer, decoding::Framer, BytesDeserializer, NewlineDelimitedDecoder,
+    BytesDeserializer, NewlineDelimitedDecoder, decoding::Deserializer, decoding::Framer,
 };
 
 #[derive(Debug)]

benches/distribution_statistic.rs

@@ -1,4 +1,4 @@
-use criterion::{criterion_group, criterion_main, BatchSize, Criterion};
+use criterion::{BatchSize, Criterion, criterion_group, criterion_main};
 use rand::distr::Distribution;
 use rand::{distr::Uniform, seq::SliceRandom};
 use vector::{event::metric::Sample, sinks::util::statistic::DistributionStatistic};

benches/dnstap/mod.rs

@@ -1,7 +1,7 @@
-use base64::engine::general_purpose::STANDARD;
 use base64::Engine;
+use base64::engine::general_purpose::STANDARD;
 use bytes::Bytes;
-use criterion::{criterion_group, criterion_main, BatchSize, Criterion, Throughput};
+use criterion::{BatchSize, Criterion, Throughput, criterion_group, criterion_main};
 use dnsmsg_parser::dns_message_parser::DnsParserOptions;
 use dnstap_parser::parser::DnstapParser;
 use vector::event::LogEvent;

benches/enrichment_tables.rs

@@ -1,13 +1,13 @@
 use std::time::SystemTime;
 
 use chrono::prelude::*;
-use criterion::{criterion_group, criterion_main, BatchSize, Criterion};
+use criterion::{BatchSize, Criterion, criterion_group, criterion_main};
 use vector::enrichment_tables::file::FileData;
 use vector::enrichment_tables::{
+    Condition, Table,
     file::File,
     geoip::{Geoip, GeoipConfig},
     mmdb::{Mmdb, MmdbConfig},
-    Condition, Table,
 };
 use vector_lib::enrichment::Case;
 use vrl::value::{ObjectMap, Value};
@@ -241,7 +241,7 @@ fn benchmark_enrichment_tables_geoip(c: &mut Criterion) {
     let mut group = c.benchmark_group("enrichment_tables_geoip");
     let build = |path: &str| {
         Geoip::new(GeoipConfig {
-            path: path.to_string(),
+            path: path.into(),
             locale: "en".to_string(),
         })
         .unwrap()
@@ -320,12 +320,7 @@ fn benchmark_enrichment_tables_geoip(c: &mut Criterion) {
 
 fn benchmark_enrichment_tables_mmdb(c: &mut Criterion) {
     let mut group = c.benchmark_group("enrichment_tables_mmdb");
-    let build = |path: &str| {
-        Mmdb::new(MmdbConfig {
-            path: path.to_string(),
-        })
-        .unwrap()
-    };
+    let build = |path: &str| Mmdb::new(MmdbConfig { path: path.into() }).unwrap();
 
     group.bench_function("enrichment_tables/mmdb_isp", |b| {
         let table = build("tests/data/GeoIP2-ISP-Test.mmdb");