Skip to content

Commit 16573a0

Browse files
committed
docs: updated comments
1 parent faaaeb2 commit 16573a0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/next/src/build/static-paths/app.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
import type { PrerenderedRoute } from './types'
88

99
describe('assignErrorIfEmpty', () => {
10-
it('should assign throwOnEmptyStaticShell false for a static route', () => {
10+
it('should assign throwOnEmptyStaticShell true for a static route with no children', () => {
1111
const prerenderedRoutes: PrerenderedRoute[] = [
1212
{
1313
params: {},
@@ -25,7 +25,7 @@ describe('assignErrorIfEmpty', () => {
2525
expect(prerenderedRoutes[0].throwOnEmptyStaticShell).toBe(true)
2626
})
2727

28-
it('should assign throwOnEmptyStaticShell to the prerendered routes', () => {
28+
it('should assign throwOnEmptyStaticShell based on route hierarchy', () => {
2929
const prerenderedRoutes: PrerenderedRoute[] = [
3030
{
3131
params: {},

packages/next/src/build/static-paths/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ export async function buildAppStaticPaths({
623623
if (hadAllParamsGenerated || isRoutePPREnabled) {
624624
if (isRoutePPREnabled) {
625625
// Discover all unique combinations of the rootParams so we can generate
626-
// shells for each of them if they're available.
626+
// routes that won't throw on empty static shell for each of them if they're available.
627627
routeParams.unshift(
628628
...filterUniqueRootParamsCombinations(rootParamKeys, routeParams)
629629
)

0 commit comments

Comments
 (0)