fix silliness, delete nearly dead apis

Author: lukesandberg

turbopack/crates/turbo-tasks-backend/src/backend/mod.rs

@@ -36,7 +36,7 @@ use turbo_tasks::{
     },
     event::{Event, EventListener},
     message_queue::TimingEvent,
-    registry::get_value_type_global_name,
+    registry::get_value_type,
     task_statistics::TaskStatisticsApi,
     trace::TraceRawVcs,
     turbo_tasks,
@@ -867,7 +867,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
 
         let _span = tracing::trace_span!(
             "recomputation",
-            cell_type = get_value_type_global_name(cell.type_id),
+            cell_type = get_value_type(cell.type_id).global_name,
             cell_index = cell.index
         )
         .entered();
@@ -3133,7 +3133,7 @@ impl DebugTraceTransientTask {
             cell_type_id: Option<ValueTypeId>,
         ) -> fmt::Result {
             if let Some(ty) = cell_type_id {
-                write!(f, " (read cell of type {})", get_value_type_global_name(ty))
+                write!(f, " (read cell of type {})", get_value_type(ty).global_name)
             } else {
                 Ok(())
             }

turbopack/crates/turbo-tasks/src/registry.rs

@@ -29,7 +29,7 @@ static FUNCTIONS: Lazy<Functions> = Lazy::new(|| {
         let global_name = native_function.global_name;
         let new = names.insert(global_name);
         debug_assert!(
-            !new,
+            new,
             "multiple functions registered with name: {global_name}!"
         );
     }
@@ -103,10 +103,6 @@ pub fn get_value_type(id: ValueTypeId) -> &'static ValueType {
     VALUES.id_to_value[*id as usize - 1]
 }
 
-pub fn get_value_type_global_name(id: ValueTypeId) -> &'static str {
-    get_value_type(id).global_name
-}
-
 struct Traits {
     id_to_trait: Box<[&'static TraitType]>,
     trait_to_id: FxHashMap<&'static TraitType, TraitTypeId>,
@@ -155,7 +151,3 @@ pub fn get_trait_type_id(trait_type: &'static TraitType) -> TraitTypeId {
 pub fn get_trait(id: TraitTypeId) -> &'static TraitType {
     TRAITS.id_to_trait[*id as usize - 1]
 }
-
-pub fn get_trait_type_global_name(id: TraitTypeId) -> &'static str {
-    get_trait(id).global_name
-}

turbopack/crates/turbo-tasks/src/task/shared_reference.rs

@@ -116,7 +116,7 @@ impl Serialize for TypedSharedReference {
         } else {
             Err(serde::ser::Error::custom(format!(
                 "{:?} is not serializable",
-                registry::get_value_type_global_name(*ty)
+                registry::get_value_type(*ty).global_name
             )))
         }
     }