[sourcemaps] Ignore-list sources whose sourcemaps ignore-list everything

Author: eps1lon

packages/next/src/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.ts

@@ -5,6 +5,7 @@ import {
   getIgnoredSources,
 } from '../../../../server/dev/middleware-webpack'
 import type { webpack } from 'next/dist/compiled/webpack/webpack'
+import type { RawSourceMap } from 'next/dist/compiled/source-map08'
 
 // Based on https://github.com/webpack/webpack/blob/fcdd04a833943394bbb0a9eeb54a962a24cc7e41/lib/stats/DefaultStatsFactoryPlugin.js#L422-L431
 /*
@@ -46,6 +47,12 @@ function getModuleTrace(input: any, compilation: any) {
   return moduleTrace
 }
 
+function sourceMapIgnoreListsEverything(
+  sourceMap: RawSourceMap & { ignoreList?: number[] }
+): boolean {
+  return sourceMap.sources.length === sourceMap.ignoreList?.length
+}
+
 async function getSourceFrame(
   input: any,
   fileName: any,
@@ -62,6 +69,8 @@ async function getSourceFrame(
       const moduleId = compilation.chunkGraph.getModuleId(module)
 
       const result = await createOriginalStackFrame({
+        // TODO
+        ignoredByDefault: sourceMapIgnoreListsEverything(sourceMap),
         source: {
           type: 'bundle',
           sourceMap,

packages/next/src/server/dev/middleware-webpack.ts

@@ -94,10 +94,13 @@ async function findOriginalSourcePositionAndContent(
   try {
     consumer = await new SourceMapConsumer(sourceMap)
   } catch (cause) {
-    throw new Error(
-      `${sourceMap.file}: Invalid source map. Only conformant source maps can be used to find the original code.`,
-      { cause }
+    console.error(
+      new Error(
+        `${sourceMap.file}: Invalid source map. Only conformant source maps can be used to find the original code.`,
+        { cause }
+      )
     )
+    return null
   }
 
   try {
@@ -178,11 +181,14 @@ function findOriginalSourcePositionAndContentFromCompilation(
 }
 
 export async function createOriginalStackFrame({
+  ignoredByDefault,
   source,
   rootDirectory,
   frame,
   errorMessage,
 }: {
+  /** setting this to true will not consult ignoreList */
+  ignoredByDefault: boolean
   source: Source
   rootDirectory: string
   frame: StackFrame
@@ -214,6 +220,7 @@ export async function createOriginalStackFrame({
   }
 
   const ignored =
+    ignoredByDefault ||
     isIgnoredSource(source, sourcePosition) ||
     // If the source file is externals, should be excluded even it's not ignored source.
     // e.g. webpack://next/dist/.. needs to be ignored
@@ -404,6 +411,12 @@ function getOriginalStackFrames({
   )
 }
 
+function sourceMapIgnoreListsEverything(
+  sourceMap: RawSourceMap & { ignoreList?: number[] }
+): boolean {
+  return sourceMap.sources.length === sourceMap.ignoreList?.length
+}
+
 async function getOriginalStackFrame({
   isServer,
   isEdgeServer,
@@ -494,8 +507,10 @@ async function getOriginalStackFrame({
       originalCodeFrame: null,
     }
   }
+  defaultStackFrame.ignored = sourceMapIgnoreListsEverything(source.sourceMap)
 
   const originalStackFrameResponse = await createOriginalStackFrame({
+    ignoredByDefault: defaultStackFrame.ignored,
     frame,
     source,
     rootDirectory,

packages/next/src/server/patch-error-inspect.ts

@@ -173,6 +173,19 @@ function createUnsourcemappedFrame(
   }
 }
 
+function sourceMapIgnoreListsEverything(
+  sourceMap: ModernSourceMapPayload
+): boolean {
+  if ('sections' in sourceMap) {
+    // If sections are present, the ignoreList is not used.
+    // This is because sections are used to ignore-list everything.
+    return sourceMap.sections.every((section) => {
+      return sourceMapIgnoreListsEverything(section.map)
+    })
+  }
+  return sourceMap.sources.length === sourceMap.ignoreList?.length
+}
+
 /**
  * @param frame
  * @param sourceMapCache
@@ -261,6 +274,7 @@ function getSourcemappedFrameIfPossible(
     line: frame.lineNumber ?? 1,
   })
 
+  let ignored = sourceMapIgnoreListsEverything(sourceMapPayload)
   if (sourcePosition.source === null) {
     return {
       stack: {
@@ -269,7 +283,7 @@ function getSourcemappedFrameIfPossible(
         file: frame.file,
         lineNumber: frame.lineNumber,
         methodName: frame.methodName,
-        ignored: shouldIgnoreListGeneratedFrame(frame.file),
+        ignored: ignored || shouldIgnoreListGeneratedFrame(frame.file),
       },
       code: null,
     }
@@ -280,18 +294,17 @@ function getSourcemappedFrameIfPossible(
     sourceMapPayload
   )
   // TODO(veil): Upstream a method to sourcemap consumer that immediately says if a frame is ignored or not.
-  let ignored = false
   if (applicableSourceMap === undefined) {
     console.error('No applicable source map found in sections for frame', frame)
-  } else if (shouldIgnoreListOriginalFrame(sourcePosition.source)) {
+  } else if (!ignored && shouldIgnoreListOriginalFrame(sourcePosition.source)) {
     // Externals may be libraries that don't ship ignoreLists.
     // This is really taking control away from libraries.
     // They should still ship `ignoreList` so that attached debuggers ignore-list their frames.
     // TODO: Maybe only ignore library sourcemaps if `ignoreList` is absent?
     // Though keep in mind that Turbopack omits empty `ignoreList`.
     // So if we establish this convention, we should communicate it to the ecosystem.
     ignored = true
-  } else {
+  } else if (!ignored) {
     // TODO: O(n^2). Consider moving `ignoreList` into a Set
     const sourceIndex = applicableSourceMap.sources.indexOf(
       sourcePosition.source

test/e2e/app-dir/server-source-maps/server-source-maps.test.ts

@@ -506,10 +506,8 @@ describe('app-dir - server source maps', () => {
            "stack": [
              "eval app/module-evaluation/module.js (1:22)",
              "<FIXME-file-protocol>",
-             "<FIXME-file-protocol>",
              "eval rsc:/Prerender/webpack-internal:///(rsc)/app/module-evaluation/page.js (5:65)",
              "<FIXME-file-protocol>",
-             "<FIXME-file-protocol>",
              "Function.all <anonymous>",
              "Function.all <anonymous>",
              "Page <anonymous>",