Skip to content

Commit 9b61916

Browse files
committed
The issue isn't with Turbopack runtime not being sourcemapped but no sourceMappingURL magic comment being emitted.
1 parent bae48d7 commit 9b61916

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

test/development/acceptance/ReactRefreshLogBox.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,6 @@ describe('ReactRefreshLogBox', () => {
471471
`
472472
)
473473

474-
// TODO(veil): ignore-list Turbopack runtime
475474
// TODO(veil): Don't bail in Turbopack for sources outside of the project (https://linear.app/vercel/issue/NDX-944)
476475
if (isReact18 && isTurbopack) {
477476
await expect(browser).toDisplayRedbox(`

test/development/acceptance/error-recovery.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ describe('pages/ error recovery', () => {
244244
`
245245
)
246246

247-
// TODO(veil): ignore-list Turbopack runtime
248247
// TODO(veil): Don't bail in Turbopack for sources outside of the project (https://linear.app/vercel/issue/NDX-944)
249248
// Somehow we end up with two in React 18 + Turbopack due to React's attempt to recover from this error.
250249
if (isReact18 && isTurbopack) {
@@ -549,7 +548,6 @@ describe('pages/ error recovery', () => {
549548
await expect(session.getRedboxSource()).resolves.toInclude('render() {')
550549
})
551550

552-
// TODO(veil): ignore-list Turbopack runtime
553551
// TODO(veil): Don't bail in Turbopack for sources outside of the project (https://linear.app/vercel/issue/NDX-944)
554552
// Somehow we end up with two in React 18 due to React's attempt to recover from this error.
555553
if (isReact18 && isTurbopack) {
@@ -681,7 +679,6 @@ describe('pages/ error recovery', () => {
681679
`
682680
)
683681

684-
// TODO(veil): ignore-list Turbopack runtime
685682
// TODO(veil): Don't bail in Turbopack for sources outside of the project (https://linear.app/vercel/issue/NDX-944)
686683
// We get an error because Foo didn't import React. Fair.
687684
// Somehow we end up with two in React 18 due to React's attempt to recover from this error.

test/e2e/app-dir/server-source-maps/server-source-maps.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,6 @@ describe('app-dir - server source maps', () => {
463463
)
464464

465465
if (isTurbopack) {
466-
// TODO(veil): Ignore-list Turbopack runtime
467466
await expect(browser).toDisplayCollapsedRedbox(`
468467
{
469468
"description": "module-evaluation",
@@ -482,7 +481,6 @@ describe('app-dir - server source maps', () => {
482481
}
483482
`)
484483
} else {
485-
// TODO(veil): Ignore-list Webpack runtime
486484
await expect(browser).toDisplayCollapsedRedbox(`
487485
{
488486
"description": "module-evaluation",

0 commit comments

Comments
 (0)