Decrease the size of turbo task object ids to u16

This probably doesn't save much memory but will save persistent db space

Author: lukesandberg

turbopack/crates/turbo-tasks/src/id.rs

@@ -119,9 +119,9 @@ macro_rules! define_id {
 }
 
 define_id!(TaskId: u32, derive(Serialize, Deserialize), serde(transparent));
-define_id!(FunctionId: u32);
-define_id!(ValueTypeId: u32);
-define_id!(TraitTypeId: u32);
+define_id!(FunctionId: u16);
+define_id!(ValueTypeId: u16);
+define_id!(TraitTypeId: u16);
 define_id!(SessionId: u32, derive(Debug, Serialize, Deserialize), serde(transparent));
 define_id!(
     LocalTaskId: u32,
@@ -166,7 +166,7 @@ macro_rules! make_serializable {
             where
                 S: serde::Serializer,
             {
-                serializer.serialize_u32(self.id.into())
+                serializer.serialize_u16(self.id.into())
             }
         }
 
@@ -175,7 +175,7 @@ macro_rules! make_serializable {
             where
                 D: serde::Deserializer<'de>,
             {
-                deserializer.deserialize_u32($visitor_name)
+                deserializer.deserialize_u16($visitor_name)
             }
         }
 
@@ -188,7 +188,7 @@ macro_rules! make_serializable {
                 formatter.write_str(concat!("an id of a registered ", stringify!($ty)))
             }
 
-            fn visit_u32<E>(self, v: u32) -> Result<Self::Value, E>
+            fn visit_u16<E>(self, v: u16) -> Result<Self::Value, E>
             where
                 E: serde::de::Error,
             {
@@ -200,7 +200,7 @@ macro_rules! make_serializable {
                             Ok(value)
                         }
                     }
-                    None => Err(E::unknown_variant(&format!("{v}"), &["a non zero u32"])),
+                    None => Err(E::unknown_variant(&format!("{v}"), &["a non zero u16"])),
                 }
             }
         }

turbopack/crates/turbo-tasks/src/registry.rs

@@ -1,4 +1,4 @@
-use std::num::NonZeroU32;
+use std::num::NonZeroU16;
 
 use anyhow::Error;
 use once_cell::sync::Lazy;
@@ -25,7 +25,7 @@ static FUNCTIONS: Lazy<Functions> = Lazy::new(|| {
     let mut value_to_id = FxHashMap::with_capacity_and_hasher(functions.len(), Default::default());
     let mut names = FxHashSet::with_capacity_and_hasher(functions.len(), Default::default());
 
-    let mut id = NonZeroU32::MIN;
+    let mut id = NonZeroU16::MIN;
     for &native_function in functions.iter() {
         value_to_id.insert(native_function, id.into());
         let global_name = native_function.global_name;
@@ -84,7 +84,7 @@ static VALUES: Lazy<Values> = Lazy::new(|| {
     // Our sort above is non-sensical if names are not unique
     let mut names = FxHashSet::with_capacity_and_hasher(all_values.len(), Default::default());
 
-    let mut id = NonZeroU32::MIN;
+    let mut id = NonZeroU16::MIN;
     for &value_type in all_values.iter() {
         value_to_id.insert(value_type, id.into());
         let global_name = value_type.global_name;
@@ -140,7 +140,7 @@ static TRAITS: Lazy<Traits> = Lazy::new(|| {
     let mut trait_to_id = FxHashMap::with_capacity_and_hasher(all_traits.len(), Default::default());
     // Our sort above is non-sensical if names are not unique
     let mut names = FxHashSet::with_capacity_and_hasher(all_traits.len(), Default::default());
-    let mut id = NonZeroU32::MIN;
+    let mut id = NonZeroU16::MIN;
     for &trait_type in all_traits.iter() {
         trait_to_id.insert(trait_type, id.into());