Skip to content

Fix command injection vulnerability in CI workflow via untrusted fork PR #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix command injection vulnerability in CI workflow via untrusted fork PR #439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52d7816
Initial plan
Copilot Nov 26, 2025
272d769
Fix command injection vulnerability in CI workflow by using environme…
Copilot Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,10 @@ jobs:
if: ${{ matrix.app.canary }}
run: |
cat packages/next/package.json | jq '.dependencies.next|="canary"' > packages/next/package.json.new && mv packages/next/package.json.new packages/next/package.json
cat workbench/${{ matrix.app.name }}/package.json | jq '.dependencies.next|="canary"' > workbench/${{ matrix.app.name }}/package.json.new && mv workbench/${{ matrix.app.name }}/package.json.new workbench/${{ matrix.app.name }}/package.json
cat "workbench/${APP_NAME}/package.json" | jq '.dependencies.next|="canary"' > "workbench/${APP_NAME}/package.json.new" && mv "workbench/${APP_NAME}/package.json.new" "workbench/${APP_NAME}/package.json"
pnpm install --no-frozen-lockfile
env:
APP_NAME: ${{ matrix.app.name }}

- name: Install Dependencies
run: pnpm install --frozen-lockfile
Expand All @@ -185,10 +187,12 @@ jobs:
run: pnpm turbo run build --filter='!./workbench/*'

- name: Resolve symlinks
run: ./scripts/resolve-symlinks.sh workbench/${{ matrix.app.name }}
run: ./scripts/resolve-symlinks.sh "workbench/${APP_NAME}"
env:
APP_NAME: ${{ matrix.app.name }}

- name: Run E2E Tests
run: cd workbench/${{ matrix.app.name }} && pnpm dev & echo "starting tests in 10 seconds" && sleep 10 && pnpm vitest run packages/core/e2e/dev.test.ts && sleep 10 && pnpm run test:e2e
run: cd "workbench/${APP_NAME}" && pnpm dev & echo "starting tests in 10 seconds" && sleep 10 && pnpm vitest run packages/core/e2e/dev.test.ts && sleep 10 && pnpm run test:e2e
env:
APP_NAME: ${{ matrix.app.name }}
DEPLOYMENT_URL: "http://localhost:${{ matrix.app.name == 'sveltekit' && '5173' || '3000' }}"
Expand Down Expand Up @@ -225,8 +229,10 @@ jobs:
if: ${{ matrix.app.canary }}
run: |
cat packages/next/package.json | jq '.dependencies.next|="canary"' > packages/next/package.json.new && mv packages/next/package.json.new packages/next/package.json
cat workbench/${{ matrix.app.name }}/package.json | jq '.dependencies.next|="canary"' > workbench/${{ matrix.app.name }}/package.json.new && mv workbench/${{ matrix.app.name }}/package.json.new workbench/${{ matrix.app.name }}/package.json
cat "workbench/${APP_NAME}/package.json" | jq '.dependencies.next|="canary"' > "workbench/${APP_NAME}/package.json.new" && mv "workbench/${APP_NAME}/package.json.new" "workbench/${APP_NAME}/package.json"
pnpm install --no-frozen-lockfile
env:
APP_NAME: ${{ matrix.app.name }}

- name: Install Dependencies
run: pnpm install --frozen-lockfile
Expand All @@ -240,7 +246,7 @@ jobs:
APP_NAME: ${{ matrix.app.name }}

- name: Run E2E Tests
run: cd workbench/${{ matrix.app.name }} && pnpm start & echo "starting tests in 10 seconds" && sleep 10 && pnpm run test:e2e
run: cd "workbench/${APP_NAME}" && pnpm start & echo "starting tests in 10 seconds" && sleep 10 && pnpm run test:e2e
env:
APP_NAME: ${{ matrix.app.name }}
DEPLOYMENT_URL: "http://localhost:${{ matrix.app.name == 'sveltekit' && '4173' || '3000' }}"
Expand Down Expand Up @@ -293,8 +299,10 @@ jobs:
if: ${{ matrix.app.canary }}
run: |
cat packages/next/package.json | jq '.dependencies.next|="canary"' > packages/next/package.json.new && mv packages/next/package.json.new packages/next/package.json
cat workbench/${{ matrix.app.name }}/package.json | jq '.dependencies.next|="canary"' > workbench/${{ matrix.app.name }}/package.json.new && mv workbench/${{ matrix.app.name }}/package.json.new workbench/${{ matrix.app.name }}/package.json
cat "workbench/${APP_NAME}/package.json" | jq '.dependencies.next|="canary"' > "workbench/${APP_NAME}/package.json.new" && mv "workbench/${APP_NAME}/package.json.new" "workbench/${APP_NAME}/package.json"
pnpm install --no-frozen-lockfile
env:
APP_NAME: ${{ matrix.app.name }}

- name: Install Dependencies
run: pnpm install --frozen-lockfile
Expand All @@ -311,7 +319,7 @@ jobs:
APP_NAME: ${{ matrix.app.name }}

- name: Run E2E Tests
run: cd workbench/${{ matrix.app.name }} && pnpm start & echo "starting tests in 10 seconds" && sleep 10 && pnpm run test:e2e
run: cd "workbench/${APP_NAME}" && pnpm start & echo "starting tests in 10 seconds" && sleep 10 && pnpm run test:e2e
env:
APP_NAME: ${{ matrix.app.name }}
DEPLOYMENT_URL: "http://localhost:${{ matrix.app.name == 'sveltekit' && '4173' || '3000' }}"
Expand Down