remove std::thread read_csv_worker, useless and buggy in seastar

Author: longqimin

include/internal/csv_reader.cpp

@@ -280,10 +280,12 @@ namespace csv {
                     return false;
                 else {
                     // Reading thread is not active => start another one
-                    if (this->read_csv_worker.joinable())
-                        this->read_csv_worker.join();
+                    // if (this->read_csv_worker.joinable())
+                    //     this->read_csv_worker.join();
+
+                    // this->read_csv_worker = std::thread(&CSVReader::read_csv, this, internals::ITERATION_CHUNK_SIZE);
+                    this->read_csv(internals::ITERATION_CHUNK_SIZE);
 
-                    this->read_csv_worker = std::thread(&CSVReader::read_csv, this, internals::ITERATION_CHUNK_SIZE);
                 }
             }
             else if (this->records->front().size() != this->n_cols &&

include/internal/csv_reader.hpp

@@ -134,9 +134,9 @@ namespace csv {
         CSVReader& operator=(const CSVReader&) = delete; // No copy assignment
         CSVReader& operator=(CSVReader&& other) = default;
         ~CSVReader() {
-            if (this->read_csv_worker.joinable()) {
-                this->read_csv_worker.join();
-            }
+            // if (this->read_csv_worker.joinable()) {
+            //     this->read_csv_worker.join();
+            // }
         }
 
         /** @name Retrieving CSV Rows */
@@ -216,13 +216,14 @@ namespace csv {
 
         /** @name Multi-Threaded File Reading: Flags and State */
         ///@{
-        std::thread read_csv_worker; /**< Worker thread for read_csv() */
+        // std::thread read_csv_worker; /**< Worker thread for read_csv() */
         ///@}
 
         /** Read initial chunk to get metadata */
         void initial_read() {
-            this->read_csv_worker = std::thread(&CSVReader::read_csv, this, internals::ITERATION_CHUNK_SIZE);
-            this->read_csv_worker.join();
+            // this->read_csv_worker = std::thread(&CSVReader::read_csv, this, internals::ITERATION_CHUNK_SIZE);
+            // this->read_csv_worker.join();
+            this->read_csv(internals::ITERATION_CHUNK_SIZE);
         }
 
         void trim_header();

include/internal/csv_reader_iterator.cpp

@@ -8,8 +8,9 @@ namespace csv {
     /** Return an iterator to the first row in the reader */
     CSV_INLINE CSVReader::iterator CSVReader::begin() {
         if (this->records->empty()) {
-            this->read_csv_worker = std::thread(&CSVReader::read_csv, this, internals::ITERATION_CHUNK_SIZE);
-            this->read_csv_worker.join();
+            // this->read_csv_worker = std::thread(&CSVReader::read_csv, this, internals::ITERATION_CHUNK_SIZE);
+            // this->read_csv_worker.join();
+            this->read_csv(internals::ITERATION_CHUNK_SIZE);
 
             // Still empty => return end iterator
             if (this->records->empty()) return this->end();