Skip to content

Commit 60b8dde

Browse files
authored
[Bug] fix webhook config output when using make manifests (#1412)
fix webhook config output when using make manifests Signed-off-by: googs1025 <[email protected]>
1 parent 0e60f7f commit 60b8dde

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

config/webhook/manifests.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,37 +56,37 @@ webhooks:
5656
service:
5757
name: webhook-service
5858
namespace: system
59-
path: /validate-model-aibrix-ai-v1alpha1-modeladapter
59+
path: /validate-orchestration-aibrix-ai-v1alpha1-kvcache
6060
failurePolicy: Fail
61-
name: vmodeladapter.kb.io
61+
name: vkvcache-v1alpha1.kb.io
6262
rules:
6363
- apiGroups:
64-
- model.aibrix.ai
64+
- orchestration.aibrix.ai
6565
apiVersions:
6666
- v1alpha1
6767
operations:
6868
- CREATE
6969
- UPDATE
7070
resources:
71-
- modeladapters
71+
- kvcaches
7272
sideEffects: None
7373
- admissionReviewVersions:
7474
- v1
7575
clientConfig:
7676
service:
7777
name: webhook-service
7878
namespace: system
79-
path: /validate-orchestration-aibrix-ai-v1alpha1-kvcache
79+
path: /validate-model-aibrix-ai-v1alpha1-modeladapter
8080
failurePolicy: Fail
81-
name: vkvcache-v1alpha1.kb.io
81+
name: vmodeladapter.kb.io
8282
rules:
8383
- apiGroups:
84-
- orchestration.aibrix.ai
84+
- model.aibrix.ai
8585
apiVersions:
8686
- v1alpha1
8787
operations:
8888
- CREATE
8989
- UPDATE
9090
resources:
91-
- kvcaches
91+
- modeladapters
9292
sideEffects: None

pkg/webhook/kvcache_webhook.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func (d *KVCacheCustomDefaulter) Default(_ context.Context, obj runtime.Object)
8181
// TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.
8282
// NOTE: The 'path' attribute must follow a specific pattern and should not be modified directly here.
8383
// Modifying the path for an invalid path can cause API server errors; failing to locate the webhook.
84-
// +kubebuilder:webhook:path=/validate-orchestration-aibrix-ai-v1alpha1-kvcache,mutating=true,failurePolicy=fail,sideEffects=None,groups=orchestration.aibrix.ai,resources=kvcaches,verbs=create;update,versions=v1alpha1,name=vkvcache-v1alpha1.kb.io,admissionReviewVersions=v1
84+
// +kubebuilder:webhook:path=/validate-orchestration-aibrix-ai-v1alpha1-kvcache,mutating=false,failurePolicy=fail,sideEffects=None,groups=orchestration.aibrix.ai,resources=kvcaches,verbs=create;update,versions=v1alpha1,name=vkvcache-v1alpha1.kb.io,admissionReviewVersions=v1
8585

8686
// KVCacheCustomValidator struct is responsible for validating the KVCache resource
8787
// when it is created, updated, or deleted.

0 commit comments

Comments
 (0)