Refactor example prompts fixture #29854
Open
+25
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I'm taking on the task of improving
conftest.py, focusing on type definitions and general code & fixtures improvements, with the objective of creating a better overall testing experience from the perspectives of readability/approachability and test completion time.This PR focuses on two things:
1. Using list comprehension for
example_promptswithout list concatenation.This change is not trivial as it might appear, given that this
fixtureis heavily used across multiple tests suites2. Improving type definitions and type inference for better IDE type hints
a.
tokenizerb.
self.model.generate(...)Test Plan
N/A
Test Result
N/A