feat: farcaster miniapp support #1383
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboletaire
force-pushed
the
f/fc-miniapp
branch
from
83e2f28 to
672314e
Compare
elboletaire
force-pushed
the
f/fc-miniapp
branch
from
672314e to
e2e2789
Compare
elboletaire
force-pushed
the
f/fc-miniapp
branch
from
e2e2789 to
5f29d6c
Compare
elboletaire
force-pushed
the
f/fc-miniapp
branch
from
5f29d6c to
3f1e73f
Compare
elboletaire
force-pushed
the
f/fc-miniapp
branch
from
3f1e73f to
362541b
Compare
elboletaire
force-pushed
the
f/fc-miniapp
branch
from
362541b to
84c1da6
Compare
elboletaire
force-pushed
the
f/fc-miniapp
branch
from
84c1da6 to
44fd384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this PR won't get merged anytime soon due to a limitation in the farcaster wallet protocol: they do not accept ascii messages when signing requests, and our Vocdoni SDK does not have a way to change this, so we currently cannot sign vochain requests in farcaster.
I'll keep the PR open as draft for some time, since it will be a good reference for changes I should also do to davinci-ui.