Skip to content

Commit b9893a1

Browse files
refactor(typescript): drop createAsyncLanguageServicePlugin API (#272)
1 parent e828089 commit b9893a1

File tree

3 files changed

+1
-124
lines changed

3 files changed

+1
-124
lines changed

β€Žpackages/typescript/lib/node/proxyLanguageService.tsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const windowsPathReg = /\\/g;
4444
* Creates and returns a Proxy around the base TypeScript LanguageService.
4545
*
4646
* This is used by the Volar TypeScript Plugin (which can be created by `createLanguageServicePlugin`
47-
* and `createAsyncLanguageServicePlugin`) as an adapter layer between the TypeScript Language Service
47+
* as an adapter layer between the TypeScript Language Service
4848
* plugin API (see https://github.com/microsoft/TypeScript/wiki/Writing-a-Language-Service-Plugin)
4949
* and a Volar `Language`.
5050
*

β€Žpackages/typescript/lib/quickstart/createAsyncLanguageServicePlugin.tsβ€Ž

Lines changed: 0 additions & 121 deletions
This file was deleted.

β€Žpackages/typescript/lib/quickstart/createLanguageServicePlugin.tsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ export function createLanguageServicePlugin(
2323
.map(plugin => plugin.typescript?.extraFileExtensions.map(ext => '.' + ext.extension) ?? [])
2424
.flat();
2525

26-
// TODO: this logic does not seem to appear in the async variant
27-
// (createAsyncLanguageServicePlugin)... bug?
2826
projectExternalFileExtensions.set(info.project, extensions);
2927

3028
const { proxy, initialize } = createProxyLanguageService(info.languageService);

0 commit comments

Comments
Β (0)