Skip to content

Commit ea5e272

Browse files
authored
Merge branch 'vueComponent:main' into feat/imagePreviewPlaceholder
2 parents 9f465b2 + 723bb47 commit ea5e272

File tree

7 files changed

+30
-22
lines changed

7 files changed

+30
-22
lines changed

.github/workflows/codecov.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
uses: actions/checkout@v2
1111

1212
- name: cache package-lock.json
13-
uses: actions/cache@v1
13+
uses: actions/cache@v4
1414
with:
1515
path: package-temp-dir
1616
key: lock-${{ github.sha }}
@@ -27,7 +27,7 @@ jobs:
2727
2828
- name: cache node_modules
2929
id: node_modules_cache_id
30-
uses: actions/cache@v1
30+
uses: actions/cache@v4
3131
with:
3232
path: node_modules
3333
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}
@@ -52,13 +52,13 @@ jobs:
5252
# submodules: true
5353

5454
- name: restore cache from package-lock.json
55-
uses: actions/cache@v1
55+
uses: actions/cache@v4
5656
with:
5757
path: package-temp-dir
5858
key: lock-${{ github.sha }}
5959

6060
- name: restore cache from node_modules
61-
uses: actions/cache@v1
61+
uses: actions/cache@v4
6262
with:
6363
path: node_modules
6464
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}

.github/workflows/test.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
uses: actions/checkout@v2
1111

1212
- name: cache package-lock.json
13-
uses: actions/cache@v2
13+
uses: actions/cache@v4
1414
with:
1515
path: package-temp-dir
1616
key: lock-${{ github.sha }}
@@ -27,7 +27,7 @@ jobs:
2727
2828
- name: cache node_modules
2929
id: node_modules_cache_id
30-
uses: actions/cache@v2
30+
uses: actions/cache@v4
3131
with:
3232
path: node_modules
3333
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}
@@ -43,25 +43,25 @@ jobs:
4343
uses: actions/checkout@v2
4444

4545
- name: restore cache from package-lock.json
46-
uses: actions/cache@v2
46+
uses: actions/cache@v4
4747
with:
4848
path: package-temp-dir
4949
key: lock-${{ github.sha }}
5050

5151
- name: restore cache from node_modules
52-
uses: actions/cache@v2
52+
uses: actions/cache@v4
5353
with:
5454
path: node_modules
5555
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}
5656

5757
- name: cache lib
58-
uses: actions/cache@v2
58+
uses: actions/cache@v4
5959
with:
6060
path: lib
6161
key: lib-${{ github.sha }}
6262

6363
- name: cache es
64-
uses: actions/cache@v2
64+
uses: actions/cache@v4
6565
with:
6666
path: es
6767
key: es-${{ github.sha }}
@@ -77,13 +77,13 @@ jobs:
7777
uses: actions/checkout@v2
7878

7979
- name: restore cache from package-lock.json
80-
uses: actions/cache@v2
80+
uses: actions/cache@v4
8181
with:
8282
path: package-temp-dir
8383
key: lock-${{ github.sha }}
8484

8585
- name: restore cache from node_modules
86-
uses: actions/cache@v2
86+
uses: actions/cache@v4
8787
with:
8888
path: node_modules
8989
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}
@@ -99,13 +99,13 @@ jobs:
9999
uses: actions/checkout@v2
100100

101101
- name: restore cache from package-lock.json
102-
uses: actions/cache@v2
102+
uses: actions/cache@v4
103103
with:
104104
path: package-temp-dir
105105
key: lock-${{ github.sha }}
106106

107107
- name: restore cache from node_modules
108-
uses: actions/cache@v2
108+
uses: actions/cache@v4
109109
with:
110110
path: node_modules
111111
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}

components/button/demo/icon.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ If you want specific control over the positioning and placement of the `Icon`, t
2121

2222
<template>
2323
<a-space direction="vertical">
24-
<a-space warp>
24+
<a-space wrap>
2525
<a-tooltip title="search">
2626
<a-button type="primary" shape="circle" :icon="h(SearchOutlined)" />
2727
</a-tooltip>
@@ -32,7 +32,7 @@ If you want specific control over the positioning and placement of the `Icon`, t
3232
</a-tooltip>
3333
<a-button :icon="h(SearchOutlined)">Search</a-button>
3434
</a-space>
35-
<a-space warp>
35+
<a-space wrap>
3636
<a-tooltip title="search">
3737
<a-button shape="circle" :icon="h(SearchOutlined)" />
3838
</a-tooltip>

components/slider/style/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ const genBaseStyle: GenerateStyle<SliderToken> = token => {
182182
borderRadius: '50%',
183183
cursor: 'pointer',
184184
transition: `border-color ${token.motionDurationSlow}`,
185+
pointerEvents: 'auto',
185186

186187
'&-active': {
187188
borderColor: token.colorPrimaryBorder,

components/vc-select/BaseSelect.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -840,6 +840,7 @@ export default defineComponent({
840840
customizeRawInputElement,
841841
{
842842
ref: selectorDomRef,
843+
tabindex: 0,
843844
},
844845
false,
845846
true,
@@ -877,7 +878,11 @@ export default defineComponent({
877878

878879
// Render raw
879880
if (customizeRawInputElement) {
880-
renderNode = selectorNode;
881+
renderNode = (
882+
<div onKeydown={onInternalKeyDown} onKeyup={onInternalKeyUp}>
883+
{selectorNode}
884+
</div>
885+
);
881886
} else {
882887
renderNode = (
883888
<div

components/vc-select/Selector/MultipleSelector.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ const SelectSelector = defineComponent<SelectorProps>({
151151
) {
152152
const onMouseDown = (e: MouseEvent) => {
153153
onPreventMouseDown(e);
154-
props.onToggleOpen(!open);
154+
props.onToggleOpen(!props.open);
155155
};
156156
let originData = option;
157157
// For TreeSelect

components/vc-select/utils/valueUtil.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@ import type { BaseOptionType, DefaultOptionType, RawValueType, FieldNames } from
22
import { warning } from '../../vc-util/warning';
33
import type { FlattenOptionData } from '../interface';
44

5-
function getKey(data: BaseOptionType, index: number) {
5+
function getKey(data: BaseOptionType, index: number, fieldNames?: FieldNames) {
66
const { key } = data;
77
let value: RawValueType;
88

9-
if ('value' in data) {
9+
if (fieldNames && fieldNames.value && data[fieldNames.value] !== undefined) {
10+
({ [fieldNames.value]: value } = data);
11+
} else if ('value' in data) {
1012
({ value } = data);
1113
}
1214

@@ -54,7 +56,7 @@ export function flattenOptions<OptionType extends BaseOptionType = DefaultOption
5456
const value = data[fieldValue];
5557
// Option
5658
flattenList.push({
57-
key: getKey(data, flattenList.length),
59+
key: getKey(data, flattenList.length, fieldNames),
5860
groupOption: isGroupOption,
5961
data,
6062
label,
@@ -67,7 +69,7 @@ export function flattenOptions<OptionType extends BaseOptionType = DefaultOption
6769
}
6870
// Option Group
6971
flattenList.push({
70-
key: getKey(data, flattenList.length),
72+
key: getKey(data, flattenList.length, fieldNames),
7173
group: true,
7274
data,
7375
label: grpLabel,

0 commit comments

Comments
 (0)