Skip to content

fix(runtime-vapor): prevent hasOwnProperty error when props is null #13564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025
Merged

fix(runtime-vapor): prevent hasOwnProperty error when props is null #13564

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a176070
fix(runtime-vapor): prevent hasOwnProperty error when dynamic prop is…
zhiyuanzmj Jul 4, 2025
11aa418
Merge branch 'vapor' into v-bind-null
zhiyuanzmj Jul 4, 2025
af1f08c
chore: add test
zhiyuanzmj Jul 4, 2025
980ea70
Apply suggestions from code review
edison1105 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion packages/runtime-vapor/__tests__/vdomInterop.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,26 @@ import { createComponent, defineVaporComponent } from '../src'
const define = makeInteropRender()

describe('vdomInterop', () => {
describe.todo('props', () => {})
describe('props', () => {
test('prevent hasOwnProperty error when props is null', () => {
const VaporChild = defineVaporComponent({
props: {
msg: String,
},
setup(_, { attrs }) {
return [document.createTextNode(attrs.class || 'foo')]
},
})

const { html } = define({
setup() {
return () => h(VaporChild as any)
},
}).render()

expect(html()).toBe('foo')
})
})

describe.todo('emit', () => {})

Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-vapor/src/componentProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export function getAttrFromRawProps(rawProps: RawProps, key: string): unknown {
source = dynamicSources[i]
isDynamic = isFunction(source)
source = isDynamic ? (source as Function)() : source
if (hasOwn(source, key)) {
if (source && hasOwn(source, key)) {
const value = isDynamic ? source[key] : source[key]()
if (merged) {
merged.push(value)
Expand Down