From b79ce58e7478e5a553414bdb26f372483f6578fc Mon Sep 17 00:00:00 2001
From: Tofandel <adrien.foulon@tukan.hu>
Date: Wed, 16 Aug 2023 21:27:37 +0200
Subject: [PATCH 1/3] fix(compiler-core): add isTemplateFor to ast of For nodes

---
 .../compiler-core/__tests__/transforms/vFor.spec.ts   | 11 +++++++++++
 packages/compiler-core/src/ast.ts                     |  1 +
 packages/compiler-core/src/transforms/vFor.ts         |  4 +++-
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/packages/compiler-core/__tests__/transforms/vFor.spec.ts b/packages/compiler-core/__tests__/transforms/vFor.spec.ts
index 1c7646e5e28..75d18ac7ef9 100644
--- a/packages/compiler-core/__tests__/transforms/vFor.spec.ts
+++ b/packages/compiler-core/__tests__/transforms/vFor.spec.ts
@@ -202,6 +202,17 @@ describe('compiler: v-for', () => {
       expect(forNode.valueAlias).toBeUndefined()
       expect((forNode.source as SimpleExpressionNode).content).toBe('items')
     })
+
+    test('is template property', () => {
+      const { node: spanForNode } = parseWithForTransform(
+          '<span v-for="index in 5" />'
+      )
+      const { node: templateForNode } = parseWithForTransform(
+          '<template v-for="index in 5" />'
+      )
+      expect(spanForNode.isTemplateFor).toBe(false)
+      expect(templateForNode.isTemplateFor).toBe(true)
+    })
   })
 
   describe('errors', () => {
diff --git a/packages/compiler-core/src/ast.ts b/packages/compiler-core/src/ast.ts
index 515083c336a..c3500819190 100644
--- a/packages/compiler-core/src/ast.ts
+++ b/packages/compiler-core/src/ast.ts
@@ -274,6 +274,7 @@ export interface ForNode extends Node {
   parseResult: ForParseResult
   children: TemplateChildNode[]
   codegenNode?: ForCodegenNode
+  isTemplateFor?: boolean
 }
 
 export interface TextCallNode extends Node {
diff --git a/packages/compiler-core/src/transforms/vFor.ts b/packages/compiler-core/src/transforms/vFor.ts
index a44532c0d58..42de4470763 100644
--- a/packages/compiler-core/src/transforms/vFor.ts
+++ b/packages/compiler-core/src/transforms/vFor.ts
@@ -271,6 +271,7 @@ export function processFor(
 
   const { addIdentifiers, removeIdentifiers, scopes } = context
   const { source, value, key, index } = parseResult
+  const isTemplate = isTemplateNode(node)
 
   const forNode: ForNode = {
     type: NodeTypes.FOR,
@@ -280,7 +281,8 @@ export function processFor(
     keyAlias: key,
     objectIndexAlias: index,
     parseResult,
-    children: isTemplateNode(node) ? node.children : [node]
+    children: isTemplate ? node.children : [node],
+    isTemplateFor: isTemplate
   }
 
   context.replaceNode(forNode)

From bca1293cc8c33fc93efd2732f08c852ada690f07 Mon Sep 17 00:00:00 2001
From: Tofandel <adrien.foulon@tukan.hu>
Date: Thu, 17 Aug 2023 00:27:44 +0200
Subject: [PATCH 2/3] also add original template props

---
 .../compiler-core/__tests__/transforms/vFor.spec.ts | 13 +++++++++++++
 packages/compiler-core/src/ast.ts                   |  1 +
 packages/compiler-core/src/transforms/vFor.ts       |  3 ++-
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/packages/compiler-core/__tests__/transforms/vFor.spec.ts b/packages/compiler-core/__tests__/transforms/vFor.spec.ts
index 75d18ac7ef9..86c4eb77617 100644
--- a/packages/compiler-core/__tests__/transforms/vFor.spec.ts
+++ b/packages/compiler-core/__tests__/transforms/vFor.spec.ts
@@ -213,6 +213,19 @@ describe('compiler: v-for', () => {
       expect(spanForNode.isTemplateFor).toBe(false)
       expect(templateForNode.isTemplateFor).toBe(true)
     })
+
+    test('key props in template', () => {
+      const { node: spanForNode } = parseWithForTransform(
+          '<span v-for="index in 5" :key="index" />'
+      )
+      const { node: templateForNode } = parseWithForTransform(
+          '<template v-for="index in 5" :key="index" />'
+      )
+
+      expect(spanForNode.templateProps).toBeUndefined();
+      expect(templateForNode.templateProps).toHaveLength(1);
+      expect(templateForNode.templateProps![0].type).toBe(NodeTypes.DIRECTIVE);
+    })
   })
 
   describe('errors', () => {
diff --git a/packages/compiler-core/src/ast.ts b/packages/compiler-core/src/ast.ts
index c3500819190..fb90e8c2d22 100644
--- a/packages/compiler-core/src/ast.ts
+++ b/packages/compiler-core/src/ast.ts
@@ -275,6 +275,7 @@ export interface ForNode extends Node {
   children: TemplateChildNode[]
   codegenNode?: ForCodegenNode
   isTemplateFor?: boolean
+  templateProps?: Array<AttributeNode | DirectiveNode>
 }
 
 export interface TextCallNode extends Node {
diff --git a/packages/compiler-core/src/transforms/vFor.ts b/packages/compiler-core/src/transforms/vFor.ts
index 42de4470763..cf2c292472c 100644
--- a/packages/compiler-core/src/transforms/vFor.ts
+++ b/packages/compiler-core/src/transforms/vFor.ts
@@ -282,7 +282,8 @@ export function processFor(
     objectIndexAlias: index,
     parseResult,
     children: isTemplate ? node.children : [node],
-    isTemplateFor: isTemplate
+    isTemplateFor: isTemplate,
+    templateProps: isTemplate ? node.props : undefined,
   }
 
   context.replaceNode(forNode)

From ac0bfcd7a4bd2692cc6bbbc9c0e6ce23d70874ed Mon Sep 17 00:00:00 2001
From: Tofandel <adrien.foulon@tukan.hu>
Date: Mon, 21 Aug 2023 13:50:24 +0200
Subject: [PATCH 3/3] prettier

---
 .../__tests__/transforms/vFor.spec.ts              | 14 +++++++-------
 packages/compiler-core/src/transforms/vFor.ts      |  2 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/packages/compiler-core/__tests__/transforms/vFor.spec.ts b/packages/compiler-core/__tests__/transforms/vFor.spec.ts
index 86c4eb77617..46bcac4e114 100644
--- a/packages/compiler-core/__tests__/transforms/vFor.spec.ts
+++ b/packages/compiler-core/__tests__/transforms/vFor.spec.ts
@@ -205,10 +205,10 @@ describe('compiler: v-for', () => {
 
     test('is template property', () => {
       const { node: spanForNode } = parseWithForTransform(
-          '<span v-for="index in 5" />'
+        '<span v-for="index in 5" />'
       )
       const { node: templateForNode } = parseWithForTransform(
-          '<template v-for="index in 5" />'
+        '<template v-for="index in 5" />'
       )
       expect(spanForNode.isTemplateFor).toBe(false)
       expect(templateForNode.isTemplateFor).toBe(true)
@@ -216,15 +216,15 @@ describe('compiler: v-for', () => {
 
     test('key props in template', () => {
       const { node: spanForNode } = parseWithForTransform(
-          '<span v-for="index in 5" :key="index" />'
+        '<span v-for="index in 5" :key="index" />'
       )
       const { node: templateForNode } = parseWithForTransform(
-          '<template v-for="index in 5" :key="index" />'
+        '<template v-for="index in 5" :key="index" />'
       )
 
-      expect(spanForNode.templateProps).toBeUndefined();
-      expect(templateForNode.templateProps).toHaveLength(1);
-      expect(templateForNode.templateProps![0].type).toBe(NodeTypes.DIRECTIVE);
+      expect(spanForNode.templateProps).toBeUndefined()
+      expect(templateForNode.templateProps).toHaveLength(1)
+      expect(templateForNode.templateProps![0].type).toBe(NodeTypes.DIRECTIVE)
     })
   })
 
diff --git a/packages/compiler-core/src/transforms/vFor.ts b/packages/compiler-core/src/transforms/vFor.ts
index cf2c292472c..b5c708dddab 100644
--- a/packages/compiler-core/src/transforms/vFor.ts
+++ b/packages/compiler-core/src/transforms/vFor.ts
@@ -283,7 +283,7 @@ export function processFor(
     parseResult,
     children: isTemplate ? node.children : [node],
     isTemplateFor: isTemplate,
-    templateProps: isTemplate ? node.props : undefined,
+    templateProps: isTemplate ? node.props : undefined
   }
 
   context.replaceNode(forNode)