Skip to content

feat(VNumberInput): do not clamp value on mounted #21826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

feat(VNumberInput): do not clamp value on mounted #21826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1ceb3f
feat(VNumberInput): do not clamp value on mounted
J-Sek Jul 26, 2025
a95b2df
chore: update tests
J-Sek Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/vuetify/src/components/VNumberInput/VNumberInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { useLocale } from '@/composables/locale'
import { useProxiedModel } from '@/composables/proxiedModel'

// Utilities
import { computed, nextTick, onMounted, ref, shallowRef, toRef, watch, watchEffect } from 'vue'
import { computed, nextTick, ref, shallowRef, toRef, watch, watchEffect } from 'vue'
import { clamp, escapeForRegex, extractNumber, genericComponent, omit, propsFactory, useRender } from '@/util'

// Types
Expand Down Expand Up @@ -194,10 +194,6 @@ export const VNumberInput = genericComponent<VNumberInputSlots>()({
watch(() => props.precision, () => formatInputValue())
watch(() => props.minFractionDigits, () => formatInputValue())

onMounted(() => {
clampModel()
})

function inferPrecision (value: number | null) {
if (value == null) return 0
const str = value.toString()
Expand Down
36 changes: 32 additions & 4 deletions packages/vuetify/src/components/VNumberInput/__tests__/VNumberInput.spec.browser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,24 +157,52 @@ describe('VNumberInput', () => {
})

describe('native number input quirks', () => {
it('should not bypass min', async () => {
it('should auto-clamp after interaction', async () => {
const model = ref(1)
render(() =>
<VNumberInput min={ 5 } max={ 15 } v-model={ model.value } />
)

await expect.element(screen.getByCSS('input')).toHaveValue('1')
expect(model.value).toBe(1)

await userEvent.click(screen.getByCSS('input'))
await userEvent.tab()

await expect.element(screen.getByCSS('input')).toHaveValue('5')
expect(model.value).toBe(5)
})

it('should not bypass max', async () => {
it('should apply increments within the range', async () => {
const model = ref(20)
render(() =>
<VNumberInput min={ 5 } max={ 15 } v-model={ model.value } />
)

await expect.element(screen.getByCSS('input')).toHaveValue('15')
expect(model.value).toBe(15)
await expect.element(screen.getByCSS('input')).toHaveValue('20')
expect(model.value).toBe(20)

await userEvent.click(screen.getByCSS('input'))
await userEvent.keyboard('{arrowDown}')

await expect.element(screen.getByCSS('input')).toHaveValue('14')
expect(model.value).toBe(14)
})

it('should auto-correct when incrementing against the limit', async () => {
const model = ref(-33)
render(() =>
<VNumberInput min={ -10 } max={ 20 } v-model={ model.value } precision={ 2 } step={ 0.5 } />
)

await expect.element(screen.getByCSS('input')).toHaveValue('-33.00')
expect(model.value).toBe(-33)

await userEvent.click(screen.getByCSS('input'))
await userEvent.keyboard('{arrowDown}')

await expect.element(screen.getByCSS('input')).toHaveValue('-10')
expect(model.value).toBe(-10)
})

it('supports decimal step', async () => {
Expand Down