Skip to content

Commit e2fd08c

Browse files
spectranautpkradaniel-montalvo
authored
Editorial: Process updates to include ACT review (#2527)
Co-authored-by: Peter Krautzberger <[email protected]> Co-authored-by: Daniel Montalvo <[email protected]>
1 parent df5d60a commit e2fd08c

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Once this PR has been reviewed and has consensus from the working group, tests s
1515
* WebKit:
1616
* Gecko:
1717
* Blink:
18+
* [ ] ACT review?
1819
* [ ] Does this need AT implementations?
1920
* [ ] Related APG Issue/PR:
2021
* [ ] MDN Issue/PR:

documentation/process.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,19 @@ A "normative" change is change to the specification that is not editorial, that
3535
- Any working group member can add themselves as a reviewer.
3636
- Any one from the general public is allowed to review PRs in order to inform the ARIA WG of approval or concerns.
3737
3. **Tests:** If the change is testable, tests should be add to the validators directory or WPT repo before merging, or, if the PR owner does not have the expertise to write tests, issues should be file in the ARIA repository as a follow up. See [Aria Test Overview](tests.md).
38-
4. **APG:** If the change requires a change to the [APG](https://github.com/w3c/aria-practices), an issue on the APG should be made describing the change.
39-
5. **Implementation:** If the change requires implementation changes, issues should be opened on the browser after the PR has been approved.
40-
- At least one implementation is required for merge. Implementation or implementation commitment from two browsers is required for merge.
38+
4. **APG:** If the PR will required changes to the [APG](https://github.com/w3c/aria-practices), an issue on the APG should be made describing the change.
39+
5. **ACT Review:** If the PR will require [ACT rules](https://www.w3.org/WAI/standards-guidelines/act/rules/) changes, then the label "needs ACT review" must be added. This will trigger the process of triage and potentially review by the [ACT Task Force](https://www.w3.org/WAI/about/groups/task-forces/conformance-testing/). When the PR has been reviewed and concerns resolved, the ACT Task Force will mark the PR as approved by checking the box in the PR tracking list in the description of the PR. The label may be added at different times:
40+
- If the change introduces an "authors must", or if the editors think the change will have a significant effect on authors, the label should be added the same time reviewers are requested.
41+
- If the change minimally effects authors, the label can be added when issues are opened on browsers.
42+
6. **Implementation:** If the change requires implementation changes, issues should be opened on the browser after the PR has been approved and tests have been authored.
43+
- At least one implementation is required for merge. Implementation or implementation commitment from two browsers is required for merge.
4144

4245
Note: The fact that a PR requires implementation to merge is new as of 2022. We understand this will cause the life of a PR to be long -- and that the original champion of the PR might need to hand off work to another ARIA WG member while the PR waits for implementations.
4346

47+
#### After merge
48+
49+
1. If the change introduces, removes or affects existing "Author MUST" statements, open issues on validators.
50+
4451
#### Stages of a normative change
4552

4653
##### Stage one: `Waiting for Review`

0 commit comments

Comments
 (0)