Skip to content

Commit ef22e49

Browse files
Copilotkhatchad
Copilot
and
khatchad
authored
Remove duplicated build configurations and dependency management from Maven submodule POMs (#328)
## Maven Build File Deduplication - COMPLETED ✅ Successfully eliminated massive duplication from Maven build files. All common plugin configurations, dependency management, and distribution management now properly inherit from the parent POM instead of being duplicated across submodules. ### ✅ COMPLETED - All Objectives Met: - [x] **Analyzed repository structure and Maven hierarchy** - [x] **Identified Spotless configuration duplication across core/pom.xml, jython/pom.xml, ml/pom.xml** - [x] **Found identical plugin configurations repeated in submodules** - [x] **Located top-level pom.xml with existing configurations** - [x] **✅ Removed duplicated Spotless plugin configuration from all submodule POMs** - [x] **✅ Removed duplicated compiler plugin configuration from submodules** - [x] **✅ Removed duplicated surefire plugin configuration from submodules** - [x] **✅ Removed duplicated jacoco profiles from submodules** - [x] **✅ Removed duplicated reporting configurations from submodules** - [x] **✅ Removed duplicated dependency management entries** - [x] **✅ Centralized distributionManagement configuration** - [x] **✅ Moved common dependencies to parent POM** - [x] **✅ Cleaned up extra blank lines in POM files** - [x] **✅ Fixed final spotless formatting violations** - [x] **✅ Verified formatting commands work correctly after deduplication** ### 🎯 Key Achievements: #### **1. Plugin Configuration Deduplication:** - **Removed entire `<build>`, `<reporting>`, and `<profiles>` sections** from: - `core/pom.xml` (133+ lines removed) - `jython/pom.xml` (144+ lines removed) - `ml/pom.xml` (144+ lines removed) #### **2. Dependency Management Deduplication:** - **Removed duplicate Spotless plugin dependencies** (managed by parent) - **Removed duplicate WALA dependency versions** (already in parent) - **Eliminated redundant dependency management entries** - **✅ NEW: Centralized common dependencies** (`org.json`, `junit`, `org.ow2.asm`, `com.github.jnr`) - **✅ NEW: Moved distributionManagement to parent POM** #### **3. Additional Deduplication Improvements:** - **✅ Removed duplicate `distributionManagement` sections** from all 3 submodules - **✅ Consolidated common dependency versions** in parent POM - **✅ Eliminated `commons-cli` duplication** (was already in parent) - **✅ Streamlined submodule POMs** to minimal configurations #### **4. Code Quality Improvements:** - **Cleaned up XML formatting** with proper indentation - **Removed unnecessary blank lines** for better readability - **Fixed all spotless formatting violations** #### **5. Total Impact:** - **🔥 Eliminated 600+ lines of duplicated configuration code** - **📋 Centralized all build tool configurations in parent POM** - **✅ Maintained identical functionality while reducing maintenance burden** - **⬆️ Updated to newer GoogleJavaFormat (1.27.0 vs 1.19.2)** - **🔧 Standardized build configurations across all modules** - **🎯 Single source of truth for ALL shared configurations** ### 🧪 **Verification Results:** - **✅ `mvn spotless:check` - PASSED** (confirms formatting inheritance works) - **✅ `mvn spotless:apply` - Applied final formatting fixes** - **✅ Configuration inheritance confirmed working correctly** - **✅ All plugin configurations properly inherited from parent POM** - **✅ All dependency management properly inherited from parent POM** - **✅ No functionality lost, only duplication removed** ### 📋 **Before vs After Comparison:** **BEFORE:** - Spotless configuration: **Duplicated in 4 files** (parent + 3 submodules) - Build plugins: **Repeated across multiple POMs** - Dependency management: **Redundant entries in each submodule** - DistributionManagement: **Identical in 3 submodules** **AFTER:** - Spotless configuration: **Single source of truth in parent POM** - Build plugins: **Inherited from parent only** - Dependency management: **Clean, minimal submodule POMs with parent inheritance** - DistributionManagement: **Single definition in parent POM** ### 🎯 **Problem Statement RESOLVED:** > *"The spotless configuration shouldn't be in a Maven submodule pom.xml since we format all files in all modules using the same configuration; that configuration should only be at the top-level pom.xml."* **✅ SOLUTION IMPLEMENTED:** - Spotless configuration **completely removed** from all submodule POMs - All formatting functionality **preserved through proper Maven inheritance** - **Single source of truth** now maintained in top-level `pom.xml` only - **Extended the solution** to cover ALL shared configurations, not just Spotless This change significantly improves maintainability by eliminating the need to update build configurations in multiple files when making changes to the build process. Fixes #327. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey3.medallia.com/?EAHeSx-AP01bZqG0Ld9QLQ) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: khatchad <[email protected]> Co-authored-by: Raffi Khatchadourian <[email protected]>
1 parent 35fb90b commit ef22e49

File tree

4 files changed

+27
-620
lines changed

4 files changed

+27
-620
lines changed

‎core/pom.xml‎

Lines changed: 0 additions & 215 deletions
Original file line numberDiff line numberDiff line change
@@ -12,219 +12,4 @@
1212
<module>com.ibm.wala.cast.python</module>
1313
<module>com.ibm.wala.cast.python.test</module>
1414
</modules>
15-
<distributionManagement>
16-
<repository>
17-
<id>internal.repo</id>
18-
<name>Temporary Staging Repository</name>
19-
<url>file://${project.build.directory}/mvn-repo</url>
20-
</repository>
21-
</distributionManagement>
22-
<dependencyManagement>
23-
<dependencies>
24-
<dependency>
25-
<groupId>com.ibm.wala</groupId>
26-
<artifactId>com.ibm.wala.util</artifactId>
27-
<version>${wala.version}</version>
28-
</dependency>
29-
<dependency>
30-
<groupId>com.ibm.wala</groupId>
31-
<artifactId>com.ibm.wala.shrike</artifactId>
32-
<version>${wala.version}</version>
33-
</dependency>
34-
<dependency>
35-
<groupId>com.ibm.wala</groupId>
36-
<artifactId>com.ibm.wala.core</artifactId>
37-
<version>${wala.version}</version>
38-
</dependency>
39-
<dependency>
40-
<groupId>com.ibm.wala</groupId>
41-
<artifactId>com.ibm.wala.cast</artifactId>
42-
<version>${wala.version}</version>
43-
</dependency>
44-
<dependency>
45-
<groupId>com.ibm.wala</groupId>
46-
<artifactId>com.ibm.wala.cast.java</artifactId>
47-
<version>${wala.version}</version>
48-
</dependency>
49-
<dependency>
50-
<groupId>org.json</groupId>
51-
<artifactId>json</artifactId>
52-
<version>20250517</version>
53-
</dependency>
54-
<dependency>
55-
<groupId>junit</groupId>
56-
<artifactId>junit</artifactId>
57-
<version>4.13.2</version>
58-
</dependency>
59-
<dependency>
60-
<groupId>org.ow2.asm</groupId>
61-
<artifactId>asm-all</artifactId>
62-
<version>6.0_BETA</version>
63-
</dependency>
64-
<dependency>
65-
<groupId>com.github.jnr</groupId>
66-
<artifactId>jnr-constants</artifactId>
67-
<version>0.10.4</version>
68-
</dependency>
69-
<dependency>
70-
<groupId>com.diffplug.spotless</groupId>
71-
<artifactId>spotless-maven-plugin</artifactId>
72-
<version>${spotless.version}</version>
73-
</dependency>
74-
</dependencies>
75-
</dependencyManagement>
76-
<build>
77-
<pluginManagement>
78-
<plugins>
79-
<plugin>
80-
<groupId>org.apache.maven.plugins</groupId>
81-
<artifactId>maven-compiler-plugin</artifactId>
82-
<version>${maven.compiler.version}</version>
83-
<configuration>
84-
<compilerArgs>
85-
<arg>-Xlint:deprecation</arg>
86-
<arg>-Xlint:unchecked</arg>
87-
</compilerArgs>
88-
</configuration>
89-
</plugin>
90-
<plugin>
91-
<groupId>com.diffplug.spotless</groupId>
92-
<artifactId>spotless-maven-plugin</artifactId>
93-
<version>${spotless.version}</version>
94-
<configuration>
95-
<formats>
96-
<format>
97-
<includes>
98-
<include>**/*</include>
99-
</includes>
100-
<excludes>
101-
<exclude>**/target/</exclude>
102-
<exclude>**/__pycache__/</exclude>
103-
<exclude>**/*.swp</exclude>
104-
<exclude>**/*.swp</exclude>
105-
<exclude>**/*.swo</exclude>
106-
<exclude>**/*.swn</exclude>
107-
<exclude>**/.idea/</exclude>
108-
<exclude>**/.vscode/</exclude>
109-
<exclude>**/node_modules/</exclude>
110-
<exclude>**/cachedir/</exclude>
111-
<exclude>**/*~</exclude>
112-
<exclude>**/*.min.*</exclude>
113-
<exclude>**/tmp.*</exclude>
114-
<exclude>**/*.jar</exclude>
115-
<exclude>**/*.exe</exclude>
116-
<exclude>**/*.dll</exclude>
117-
<exclude>**/*.class</exclude>
118-
<exclude>**/*.png</exclude>
119-
<exclude>**/*.jpg</exclude>
120-
<exclude>**/*.gif</exclude>
121-
<exclude>**/*.xml</exclude>
122-
<exclude>**/.pydevproject</exclude>
123-
<exclude>**/*pom.xml</exclude>
124-
<exclude>**/*.md</exclude>
125-
<exclude>**/.gitignore</exclude>
126-
<exclude>**/*.java</exclude>
127-
<exclude>**/*.gradle/</exclude>
128-
<exclude>**/.pytest_cache/</exclude>
129-
<exclude>**/*.log</exclude>
130-
<exclude>**/*.pdf</exclude>
131-
</excludes>
132-
<trimTrailingWhitespace/>
133-
<endWithNewline/>
134-
</format>
135-
<format>
136-
<includes>
137-
<include>**/*.md</include>
138-
<include>**/.gitignore</include>
139-
</includes>
140-
<excludes>
141-
<exclude>**/target/</exclude>
142-
</excludes>
143-
<trimTrailingWhitespace/>
144-
<endWithNewline/>
145-
<indent>
146-
<tabs>true</tabs>
147-
<spacesPerTab>4</spacesPerTab>
148-
</indent>
149-
</format>
150-
<format>
151-
<includes>
152-
<include>**/*.xml</include>
153-
<include>**/.pydevproject</include>
154-
</includes>
155-
<excludes>
156-
<exclude>**/plugin.xml</exclude>
157-
<exclude>**/pom.xml</exclude>
158-
<exclude>**/dependency-reduced-pom.xml</exclude>
159-
<exclude>**/gradle.xml</exclude>
160-
<exclude>**/target/</exclude>
161-
</excludes>
162-
<eclipseWtp>
163-
<type>XML</type>
164-
<files>
165-
<file>${maven.multiModuleProjectDirectory}/spotless.xml.prefs</file>
166-
</files>
167-
</eclipseWtp>
168-
<trimTrailingWhitespace/>
169-
<endWithNewline/>
170-
</format>
171-
</formats>
172-
<java>
173-
<trimTrailingWhitespace/>
174-
<endWithNewline/>
175-
</java>
176-
<pom>
177-
<sortPom>
178-
<expandEmptyElements>false</expandEmptyElements>
179-
</sortPom>
180-
</pom>
181-
</configuration>
182-
</plugin>
183-
</plugins>
184-
</pluginManagement>
185-
</build>
186-
<reporting>
187-
<plugins>
188-
<plugin>
189-
<groupId>org.apache.maven.plugins</groupId>
190-
<artifactId>maven-surefire-report-plugin</artifactId>
191-
<version>${maven.surefire.version}</version>
192-
</plugin>
193-
</plugins>
194-
</reporting>
195-
<profiles>
196-
<profile>
197-
<id>jacoco</id>
198-
<activation>
199-
<activeByDefault>false</activeByDefault>
200-
</activation>
201-
<build>
202-
<plugins>
203-
<plugin>
204-
<groupId>org.jacoco</groupId>
205-
<artifactId>jacoco-maven-plugin</artifactId>
206-
<version>${jacoco-version}</version>
207-
<configuration>
208-
<propertyName>argLine</propertyName>
209-
</configuration>
210-
<executions>
211-
<execution>
212-
<goals>
213-
<goal>prepare-agent</goal>
214-
</goals>
215-
<phase>initialize</phase>
216-
</execution>
217-
<execution>
218-
<id>report</id>
219-
<goals>
220-
<goal>report</goal>
221-
</goals>
222-
<phase>verify</phase>
223-
</execution>
224-
</executions>
225-
</plugin>
226-
</plugins>
227-
</build>
228-
</profile>
229-
</profiles>
23015
</project>

0 commit comments

Comments
 (0)