Patch for TB 68

[rzroth]

I made a hacked version (notes below) you can find at:
http://www.tnrglobal.com/2020/05/thunderbird-addons/
Hack issues:
1) It does require TB restart although it doesn't report that.
2) I've mainly used search and Ctl-Shift FIELD for searching,
SO please try your favorite options and let me know if it works.
3) I don't have access to add better update info
4) FYI, This is a legacy mode extension

I call it hacked because I not a extension pro, even if I am a Kernel level professional programmer.
good luck. It is not in any way compromised as many use hacked to mean.
If I get github access I will make a branch for this.

[Harliff]

I'm just installed it and tested.
@rzroth, thanks for your work!

[karlbu]

Hello rzroth. Thank you for continuing to develop expression search for current versions of T-Bird. Greatly appreciated.

I installed 1.4.2-tb.xpi into version 68.9. While T-Bird launched, I could not access any emails. Nor could I access the Add-ons module to uninstall it. I uploaded the console error report as a word file to this post. (Did not know how to export the file.)

console error 20200604.docx

[gabbello]

Man this is awesome

[markwmuller]

While this sounds promising, I would strongly caution against installing something from a website that doesn't even have HTTPS set up, where the dev claims they don't have github access (from a github account -- what access is lacking? Anyone can fork their repo and develop there)

[aleqx]

While this sounds promising, I would strongly caution against installing something from a website that doesn't even have HTTPS set up, where the dev claims they don't have github access (from a github account -- what access is lacking? Anyone can fork their repo and develop there)

@markwmuller I second that. That being said, though, the .xpi is just a zip which you can unpack and verify the Javascript code for any malicious/suspicious actions (I haven't done that myself).

[Roy-Orbison]

@markwmuller

I would strongly caution against installing something from a website that doesn't even have HTTPS set up

It's unlikely anyone has a MITM attack server on people's routes but, yes, HTTPS would be better.

the dev claims they don't have github access (from a github account -- what access is lacking?

They're talking about write access on the existing repository.

It's still wise to exercise caution, but remember that .xpi files are just zip archives, and all source on an extension can be inspected.

@rzroth We appreciate your work, but could you please fork the repo on Github, commit the changes to your fork, then open a pull request? Then everyone can see what's changed and why.

[daniel-lo]

Super! Installs well on Win10Pro TB68.8.1 .. but layout needs optimisation. It seems to consist of wo fields .. the left one works .. the right on (which shouldn't be there) doesn't.

Edit: No change after updating to TB68.9.0

[riedel]

Instead of complaining I created a PR (#93) with @rzroth's commit and set him as author, please feel free to review it.

[riedel]

@rzroth: I will close my pull request if you create one. If you are unsure how there is a short documentation , e.g. here: https://opensource.com/article/19/7/create-pull-request-github

Thanks alot for your efforts. Hope you will maintain a fork of this great add-on!

[fpierrat]

@rzroth: thanks for the patch
@riedel: what do I have to install it? Just download the fork as a zip and rename this .zip to .xpi ?

[markwmuller]

Works for me, thank you @rzroth @riedel !
How to install, @fpierrat , follow these instructions https://stackoverflow.com/questions/19240653/how-to-create-xpi-file-with-7zip (I just zipped from linux file browser, renamed to .xpi, and could open it. Note the folder structure seems to matter)

[fpierrat]

Installed. Happy :-D
Just this second input field mentioned by daniel-lo above. Looks a bit strange, but it doesn't seem to affect the searches... when you type them in the left input ;-)

[gsappa]

I've tried to install it (both @rzroth xpi than following instructions reporte by @markwmuller), but it's saying that is non compatible with TB 68.10. Any suggestion?