Skip to content

Commit 7298fd7

Browse files
authored
fix: server hooks not trigger when target is others (#2303)
1 parent b3e9489 commit 7298fd7

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

packages/shared/src/utils.ts

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,20 @@ export const isClientCompiler = (compiler: {
316316
return false;
317317
};
318318

319+
const isNodeCompiler = (compiler: {
320+
options: {
321+
target?: Compiler['options']['target'];
322+
};
323+
}) => {
324+
const { target } = compiler.options;
325+
326+
if (target) {
327+
return Array.isArray(target) ? target.includes('node') : target === 'node';
328+
}
329+
330+
return false;
331+
};
332+
319333
type ServerCallbacks = {
320334
onInvalid: () => void;
321335
onDone: (stats: any) => void;
@@ -334,7 +348,8 @@ export const setupServerHooks = (
334348
},
335349
hookCallbacks: ServerCallbacks,
336350
) => {
337-
if (!isClientCompiler(compiler)) {
351+
// TODO: node ssr HMR is not supported yet
352+
if (isNodeCompiler(compiler)) {
338353
return;
339354
}
340355

0 commit comments

Comments
 (0)