fix: import.meta.prop with define plugin (#11525)

Author: ahabhgk

crates/rspack_plugin_javascript/src/parser_plugin/drive.rs

@@ -430,6 +430,21 @@ impl JavascriptParserPlugin for JavaScriptParserPluginDrive {
     None
   }
 
+  fn evaluate<'a>(
+    &self,
+    parser: &mut JavascriptParser,
+    expr: &'a Expr,
+  ) -> Option<BasicEvaluatedExpression<'a>> {
+    for plugin in &self.plugins {
+      let res = plugin.evaluate(parser, expr);
+      // `SyncBailHook`
+      if res.is_some() {
+        return res;
+      }
+    }
+    None
+  }
+
   fn evaluate_typeof<'a>(
     &self,
     parser: &mut JavascriptParser,

crates/rspack_plugin_javascript/src/parser_plugin/import_meta_plugin.rs

@@ -3,7 +3,7 @@ use rspack_core::{ConstDependency, SpanExt, property_access};
 use rspack_error::miette::Severity;
 use swc_core::{
   common::{Span, Spanned},
-  ecma::ast::{Expr, MemberProp},
+  ecma::ast::{Expr, MemberProp, MetaPropKind},
 };
 use url::Url;
 
@@ -44,7 +44,7 @@ impl JavascriptParserPlugin for ImportMetaPlugin {
     _parser: &mut JavascriptParser,
     expr: &'a swc_core::ecma::ast::UnaryExpr,
     for_name: &str,
-  ) -> Option<crate::utils::eval::BasicEvaluatedExpression<'a>> {
+  ) -> Option<eval::BasicEvaluatedExpression<'a>> {
     let mut evaluated = None;
     if for_name == expr_name::IMPORT_META {
       evaluated = Some("object".to_string());
@@ -88,6 +88,33 @@ impl JavascriptParserPlugin for ImportMetaPlugin {
     }
   }
 
+  fn evaluate<'a>(
+    &self,
+    _parser: &mut JavascriptParser,
+    expr: &'a Expr,
+  ) -> Option<eval::BasicEvaluatedExpression<'a>> {
+    if let Some(member) = expr.as_member()
+      && let Some(meta_prop) = member.obj.as_meta_prop()
+      && meta_prop.kind == MetaPropKind::ImportMeta
+    {
+      if member.prop.is_ident() {
+        return Some(eval::evaluate_to_undefined(
+          member.span().real_lo(),
+          member.span().real_hi(),
+        ));
+      }
+      if let Some(computed) = member.prop.as_computed()
+        && computed.expr.is_lit()
+      {
+        return Some(eval::evaluate_to_undefined(
+          member.span().real_lo(),
+          member.span().real_hi(),
+        ));
+      }
+    }
+    None
+  }
+
   fn r#typeof(
     &self,
     parser: &mut JavascriptParser,

crates/rspack_plugin_javascript/src/parser_plugin/trait.rs

@@ -79,6 +79,14 @@ pub trait JavascriptParserPlugin {
     None
   }
 
+  fn evaluate<'a>(
+    &self,
+    _parser: &mut JavascriptParser,
+    _expr: &'a Expr,
+  ) -> Option<BasicEvaluatedExpression<'a>> {
+    None
+  }
+
   fn evaluate_typeof<'a>(
     &self,
     _parser: &mut JavascriptParser,

crates/rspack_plugin_javascript/src/utils/eval/eval_member_expr.rs

@@ -1,5 +1,5 @@
 use rspack_core::SpanExt;
-use swc_core::ecma::ast::MemberExpr;
+use swc_core::ecma::ast::{Expr, MemberExpr};
 
 use super::BasicEvaluatedExpression;
 use crate::{
@@ -10,6 +10,7 @@ use crate::{
 pub fn eval_member_expression<'a>(
   parser: &mut JavascriptParser,
   member: &'a MemberExpr,
+  expr: &'a Expr,
 ) -> Option<BasicEvaluatedExpression<'a>> {
   let ret = if let Some(MemberExpressionInfo::Expression(info)) =
     parser.get_member_expression_info(member, AllowedMemberTypes::Expression)
@@ -23,6 +24,7 @@ pub fn eval_member_expression<'a>(
         member.span.real_lo(),
         member.span.hi().0,
       )
+      .or_else(|| parser.plugin_drive.clone().evaluate(parser, expr))
       .or_else(|| {
         // TODO: fallback with `evaluateDefinedIdentifier`
         let mut eval =

crates/rspack_plugin_javascript/src/visitors/dependency/parser/mod.rs

@@ -1141,9 +1141,9 @@ impl JavascriptParser<'_> {
             eval::eval_call_expression(parser, call_expr)
           })
         },
-        |parser, member| eval::eval_member_expression(parser, member),
+        |parser, member| eval::eval_member_expression(parser, member, expr),
       ),
-      Expr::Member(member) => eval::eval_member_expression(self, member),
+      Expr::Member(member) => eval::eval_member_expression(self, member, expr),
       Expr::Ident(ident) => {
         let name = &ident.sym;
         if name.eq("undefined") {

packages/rspack-test-tools/tests/configCases/plugins/define-plugin-import-meta/index.js

@@ -0,0 +1,5 @@
+it("should not have import.meta.env", function() {
+	var _env;
+	(_env = import.meta.env) === null || _env === void 0 ? void 0 : _env.production;
+	expect(_env).toBe(undefined);
+});

packages/rspack-test-tools/tests/configCases/plugins/define-plugin-import-meta/webpack.config.js

@@ -0,0 +1,10 @@
+var DefinePlugin = require("@rspack/core").DefinePlugin;
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	plugins: [
+		new DefinePlugin({
+			"import.meta.env.MODE": '"production"'
+		})
+	]
+};