Skip to content

Conversation

@ch0rizo
Copy link
Contributor

@ch0rizo ch0rizo commented Oct 29, 2025

Description

Added new categories, and removed non relevant categories.

I am not sure what migrations will do to old objects with not longer used categories

Testing

  • The code quality is at a minimum required level of quality, readability, and performance.
  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

Resolves ABA-1597

@linear
Copy link

linear bot commented Oct 29, 2025

@ch0rizo ch0rizo requested a review from a team October 29, 2025 21:09
@ch0rizo ch0rizo self-assigned this Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.58%. Comparing base (8542f7e) to head (2bdac11).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3861   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         359      359           
  Lines       12626    12626           
=======================================
  Hits        10427    10427           
  Misses       2199     2199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jonasdeluna jonasdeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think charfield with choices is a constraint on db level so the rows will probably be there but might be buggy when interacting with the rest of the backend.
You can write a custom Python operation to either delete then or change the category before removing the choices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants