Skip to content

all_POP doesn't need a constraint #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

all_POP doesn't need a constraint #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sop-core/src/Data/SOP/Dict.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,11 @@ all_NP (Dict :* ds) = withDict (all_NP ds) Dict
--
-- @since 0.2
--
all_POP :: SListI xss => POP (Dict c) xss -> Dict (All2 c) xss
all_POP = all2 . all_NP . hmap all_NP . unPOP
-- TODO: Is the constraint necessary?
all_POP :: POP (Dict c) xss -> Dict (All2 c) xss
all_POP = all2 . all_NP . map_NP' all_NP . unPOP where
map_NP' :: (forall x. f x -> g x) -> NP f xs -> NP g xs
map_NP' _ Nil = Nil
map_NP' f (x :* xs) = f x :* map_NP' f xs

-- | The constraint @'All2' c@ is convertible to @'All' ('All' c)@.
--
Expand Down