Skip to content

Added support for ESP32 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added support for ESP32 #6

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
200ea0e
Added support for ESP32
Lennyz1988 Mar 4, 2018
2e5a87b
Added support for ESP32
Lennyz1988 Mar 4, 2018
fb8ba08
Added support for ESP32
Lennyz1988 Mar 4, 2018
0533a9b
Added support for ESP32
Lennyz1988 Mar 4, 2018
008a9af
Added multiple instances of readers.
Lennyz1988 Mar 4, 2018
85a5798
Update README.md
Lennyz1988 Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion examples/read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ def do_read():
rdr = mfrc522.MFRC522("GP14", "GP16", "GP15", "GP22", "GP17")
elif uname()[0] == 'esp8266':
rdr = mfrc522.MFRC522(0, 2, 4, 5, 14)

elif uname()[0] == 'esp32':
rdr = mfrc522.MFRC522(18, 23, 19, 4, 2)

else:
raise RuntimeError("Unsupported platform")

Expand Down Expand Up @@ -43,4 +47,4 @@ def do_read():
print("Failed to select tag")

except KeyboardInterrupt:
print("Bye")
print("Bye")
3 changes: 3 additions & 0 deletions mfrc522.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ def __init__(self, sck, mosi, miso, rst, cs):
elif board == 'esp8266':
self.spi = SPI(baudrate=100000, polarity=0, phase=0, sck=self.sck, mosi=self.mosi, miso=self.miso)
self.spi.init()
elif board == 'esp32':
self.spi = SPI(baudrate=100000, polarity=0, phase=0, sck=self.sck, mosi=self.mosi, miso=self.miso)
self.spi.init()
Copy link

@ThomasWaldmann ThomasWaldmann Apr 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you are doing precisely the same thing as 3 lines above, how about just changing line 32 to:

elif board == 'esp8266' or board == 'esp32':

else:
raise RuntimeError("Unsupported platform")

Expand Down