Skip to content

Commit 66e162f

Browse files
author
Mirko Brodesser
authored
Editorial: change "show popover" to call "check popover validity" first
This is what implementations (at least Gecko and Chromium) do and it's analogous to what happens in "hide popover". Fixes #9429.
1 parent be5c890 commit 66e162f

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

source

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -82554,12 +82554,23 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8255482554
element</span> or null <var>invoker</var>:</p>
8255582555

8255682556
<ol>
82557+
<li><p>If the result of running <span>check popover validity</span> given <var>element</var>,
82558+
false, <var>throwExceptions</var>, and null is false, then return.</p></li>
82559+
8255782560
<li><p>Let <var>document</var> be <var>element</var>'s <span>node document</span>.</p></li>
8255882561

8255982562
<li><p><span>Assert</span>: <var>element</var>'s <span>popover invoker</span> is null.</p></li>
8256082563

8256182564
<li><p>Set <var>element</var>'s <span>popover invoker</span> to <var>invoker</var>.</p></li>
8256282565

82566+
<li><p><span>Assert</span>: <var>element</var> is not in <var>document</var>'s <span>top
82567+
layer</span>.</p></li>
82568+
82569+
<li><p>Let <var>nestedShow</var> be <var>element</var>'s <span>popover showing or
82570+
hiding</span>.</p></li>
82571+
82572+
<li><p>Set <var>element</var>'s <span>popover showing or hiding</span> to true.</p></li>
82573+
8256382574
<li>
8256482575
<p>Let <var>cleanupShowingFlag</var> be the following steps:</p>
8256582576

@@ -82569,20 +82580,6 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8256982580
</ol>
8257082581
</li>
8257182582

82572-
<li><p>If the result of running <span>check popover validity</span> given <var>element</var>,
82573-
false, <var>throwExceptions</var>, and null is false, then run <var>cleanupShowingFlag</var> and
82574-
return.</p></li>
82575-
82576-
<li><p><span>Assert</span>: <var>element</var> is not in <var>document</var>'s <span>top
82577-
layer</span>.</p></li>
82578-
82579-
<li><p>Let <var>nestedShow</var> be false.</p></li>
82580-
82581-
<li><p>If <var>element</var>'s <span>popover showing or hiding</span> is true, then set
82582-
<var>nestedShow</var> to true.</p></li>
82583-
82584-
<li><p>Set <var>element</var>'s <span>popover showing or hiding</span> to true.</p></li>
82585-
8258682583
<li><p>If the result of <span data-x="concept-event-fire">firing an event</span> named <code
8258782584
data-x="event-beforetoggle">beforetoggle</code>, using <code>ToggleEvent</code>, with the <code
8258882585
data-x="dom-Event-cancelable">cancelable</code> attribute initialized to true, the <code

0 commit comments

Comments
 (0)