From 25edd1c684073e56660a96845e44ad5006bb36cd Mon Sep 17 00:00:00 2001
From: Mirko Brodesser <mbrodesser@igalia.com>
Date: Mon, 19 Jun 2023 11:04:12 +0200
Subject: [PATCH 1/3] Change "show popover" to call "check popover validity"
 first

This is what implementations (at least Gecko and Chromium) do and it's analogous to
what happens in "hide popover".

Fixes #9429.
---
 source | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/source b/source
index 70e9a24f618..cde8a180e37 100644
--- a/source
+++ b/source
@@ -82457,6 +82457,9 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
   element</span> or null <var>invoker</var>:</p>
 
   <ol>
+   <li><p>If the result of running <span>check popover validity</span> given <var>element</var>,
+   false, <var>throwExceptions</var>, and null is false, then return.</p></li>
+
    <li><p>Let <var>document</var> be <var>element</var>'s <span>node document</span>.</p></li>
 
    <li><p><span>Assert</span>: <var>element</var>'s <span>popover invoker</span> is null.</p></li>
@@ -82472,10 +82475,6 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
     </ol>
    </li>
 
-   <li><p>If the result of running <span>check popover validity</span> given <var>element</var>,
-   false, <var>throwExceptions</var>, and null is false, then run <var>cleanupShowingFlag</var> and
-   return.</p></li>
-
    <li><p><span>Assert</span>: <var>element</var> is not in <var>document</var>'s <span>top
    layer</span>.</p></li>
 

From 112639027044093ee0dc9e39886d08b6caef8982 Mon Sep 17 00:00:00 2001
From: Mirko Brodesser <mbrodesser@igalia.com>
Date: Mon, 19 Jun 2023 11:11:48 +0200
Subject: [PATCH 2/3] Define "cleanupShowingFlag" in "show popover" after
 defining "nestedShow"

Simplifies understanding the spec.
---
 source | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/source b/source
index cde8a180e37..2e049e78b7c 100644
--- a/source
+++ b/source
@@ -82466,6 +82466,14 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
 
    <li><p>Set <var>element</var>'s <span>popover invoker</span> to <var>invoker</var>.</p></li>
 
+   <li><p><span>Assert</span>: <var>element</var> is not in <var>document</var>'s <span>top
+   layer</span>.</p></li>
+
+   <li><p>Let <var>nestedShow</var> be <var>element</var>'s <span>popover showing or hiding</span>.
+   </p></li>
+
+   <li><p>Set <var>element</var>'s <span>popover showing or hiding</span> to true.</p></li>
+
    <li>
     <p>Let <var>cleanupShowingFlag</var> be the following steps:</p>
 
@@ -82475,16 +82483,6 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
     </ol>
    </li>
 
-   <li><p><span>Assert</span>: <var>element</var> is not in <var>document</var>'s <span>top
-   layer</span>.</p></li>
-
-   <li><p>Let <var>nestedShow</var> be false.</p></li>
-
-   <li><p>If <var>element</var>'s <span>popover showing or hiding</span> is true, then set
-   <var>nestedShow</var> to true.</p></li>
-
-   <li><p>Set <var>element</var>'s <span>popover showing or hiding</span> to true.</p></li>
-
    <li><p>If the result of <span data-x="concept-event-fire">firing an event</span> named <code
    data-x="event-beforetoggle">beforetoggle</code>, using <code>ToggleEvent</code>, with the <code
    data-x="dom-Event-cancelable">cancelable</code> attribute initialized to true, the <code

From 0edd08f751869c41f3cdd6c97d6855b15c23acbd Mon Sep 17 00:00:00 2001
From: Mirko Brodesser <mbrodesser@igalia.com>
Date: Mon, 19 Jun 2023 11:55:18 +0200
Subject: [PATCH 3/3] Start new line earlier so that `.` isn't at the line's
 end

Otherwise, the rendered page would contain a space character after the
`.`.
---
 source | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source b/source
index 2e049e78b7c..1c3b6bddb03 100644
--- a/source
+++ b/source
@@ -82469,8 +82469,8 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
    <li><p><span>Assert</span>: <var>element</var> is not in <var>document</var>'s <span>top
    layer</span>.</p></li>
 
-   <li><p>Let <var>nestedShow</var> be <var>element</var>'s <span>popover showing or hiding</span>.
-   </p></li>
+   <li><p>Let <var>nestedShow</var> be <var>element</var>'s <span>popover showing or
+   hiding</span>.</p></li>
 
    <li><p>Set <var>element</var>'s <span>popover showing or hiding</span> to true.</p></li>