Skip to content

Undeclared variable makes the OTA update compile fail. #413

@burtonkent

Description

@burtonkent

Steps to reproduce if you already have Lua-RTOS-ESP32 set up to 'make':

  1. make clean to clear out past makes.
  2. make
  3. choose 8 (Espressif Systems ESP-WROVER-KIT)
  4. choose 2 (Espressif Systems ESP-WROVER-KIT with OTA)
  5. Will warn about not being able to remove directories because they're not empty. It's fine.
  6. Fails in components/sys/drivers/net.c because the variable total isn't declared before use on line 513.
    The error given is:
Lua-RTOS-ESP32/components/sys/drivers/net.c: In function 'net_ota':
<development path I'm using>/Lua-RTOS-ESP32/components/sys/drivers/net.c:513:78: error: 'total' undeclared (first use in this function)
                 int pct = (int)(((float)(address-update_partition->address))/total*100);

It's strange because git blame shows:
b22ddc9 components/sys/drivers/net.c (the0ne 2020-01-09 07:43:20 +0100 513) int pct = (int)(((float)(address-update_partition->address))/*100);
Note the 2020 commit date. I'm surprised this wasn't found as a bug before. I have to wonder if this is my error somehow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions