Get to green, then update dependencies (#526)

* Apply or suppress changes suggested by more modern rubocop.

* Fix feature execution on Ruby 3.5.0dev

cucumber-core fails on Ruby 3.5.0dev due to a change in the expected method signature for Cucumber::Core::Test::Location#from_source_location. Work around this by aliasing out the old method and then using a new proxy method to catch the method and send the old style message to the old method.

* Bump aruba, byebug, cucumber, fakefs, rake, reek dependencies

Also corrected multiple Minitest/EmptyLineBeforeAssertionMethods issues flagged by rubocop-minitst.

Author: faisal

CHANGELOG.md

@@ -1,5 +1,8 @@
 # main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...main)
 
+* [CHANGE] Bump aruba, byebug, cucumber, fakefs, rake, reek dependencies (by [@faisal][])
+* [BUGFIX] Work around issue preventing feature execution on Ruby 3.5.0dev (by [@faisal][])
+* [CHANGE] Add changes or suppress warnings for issues found by newer rubocop (by [@faisal][])
 * [CHANGE] Update CI checkout action to v4 (by [@faisal][])
 
 # v4.9.2 / 2025-04-08 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.9.1...v4.9.2)

features/support/env.rb

@@ -1,5 +1,20 @@
 # frozen_string_literal: true
 
+if RUBY_VERSION == '3.5.0' && RUBY_PATCHLEVEL == -1
+  module Cucumber
+    module Core
+      module Test
+        module Location
+          singleton_class.send(:alias_method, :original_from_source_location, :from_source_location)
+          def self.from_source_location(file, start_line, _start_column = nil, _end_line = nil, _end_column = nil)
+            original_from_source_location(file, start_line)
+          end
+        end
+      end
+    end
+  end
+end
+
 require_relative '../../lib/rubycritic'
 require_relative '../../lib/rubycritic/cli/application'
 require_relative '../../lib/rubycritic/commands/status_reporter'
@@ -11,6 +26,7 @@
 #
 class RubyCriticWorld
   extend Minitest::Assertions
+
   attr_accessor :assertions
 
   def initialize

lib/rubycritic/analysers/attributes.rb

@@ -8,6 +8,7 @@ module RubyCritic
   module Analyser
     class Attributes
       include Colorize
+
       def initialize(analysed_modules)
         @analysed_modules = analysed_modules
       end

lib/rubycritic/analysers/churn.rb

@@ -6,6 +6,7 @@ module RubyCritic
   module Analyser
     class Churn
       include Colorize
+
       attr_writer :source_control_system
 
       def initialize(analysed_modules)

lib/rubycritic/analysers/complexity.rb

@@ -7,6 +7,7 @@ module RubyCritic
   module Analyser
     class Complexity
       include Colorize
+
       def initialize(analysed_modules)
         @flog = Flog.new
         @analysed_modules = analysed_modules

lib/rubycritic/analysers/smells/flay.rb

@@ -8,6 +8,7 @@ module RubyCritic
   module Analyser
     class FlaySmells
       include Colorize
+
       def initialize(analysed_modules)
         @analysed_modules = paths_to_analysed_modules(analysed_modules)
         @flay = Flay.new(@analysed_modules.keys)

lib/rubycritic/analysers/smells/flog.rb

@@ -8,6 +8,7 @@ module RubyCritic
   module Analyser
     class FlogSmells
       include Colorize
+
       HIGH_COMPLEXITY_SCORE_THRESHOLD = 25
       VERY_HIGH_COMPLEXITY_SCORE_THRESHOLD = 60
 

lib/rubycritic/analysers/smells/reek.rb

@@ -8,6 +8,7 @@ module RubyCritic
   module Analyser
     class ReekSmells
       include Colorize
+
       def initialize(analysed_modules)
         @analysed_modules = analysed_modules
       end

lib/rubycritic/commands/status_reporter.rb

@@ -26,10 +26,10 @@ def update_status
       end
 
       def current_status
-        satisfy_minimum_score_rule ? SUCCESS : SCORE_BELOW_MINIMUM
+        satisfy_minimum_score_rule? ? SUCCESS : SCORE_BELOW_MINIMUM
       end
 
-      def satisfy_minimum_score_rule
+      def satisfy_minimum_score_rule?
         score >= @options[:minimum_score].to_f
       end
 

lib/rubycritic/rake_task.rb

@@ -71,7 +71,7 @@ def run_task
 
     def print_starting_up_output
       puts "\n\n!!! Running `#{name}` rake command\n"
-      puts "!!! Inspecting #{paths} #{options.empty? ? '' : "with options #{options}"}\n\n"
+      puts "!!! Inspecting #{paths} #{"with options #{options}" unless options.empty?}\n\n"
     end
 
     def options_as_arguments