Skip to content

Commit c7cf833

Browse files
committed
Remove support for Ruby 3.1 and the aligned JRuby 9.4, add support for JRuby 10
- rubycritic.gemspec: update minimum Ruby version to 3.2 - .rubocop.yml: update target Ruby version to 3.2 - CI: drop Ruby 3.1, and change jruby from 9.4 (Ruby 3.1) to jruby to 10 (Ruby 3.4) - add platform value to the gemspec, and require jar-dependencies version # Conflicts: # CHANGELOG.md
1 parent 0d6a2f8 commit c7cf833

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

.github/workflows/main.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,16 @@ jobs:
2929
fail-fast: false
3030
matrix:
3131
ruby-version:
32-
- '3.1'
3332
- '3.2'
3433
- '3.3'
3534
- '3.4'
3635
experimental: [false]
3736
include:
3837
- ruby-version: 'ruby-head'
3938
experimental: true
40-
- ruby-version: 'jruby-9.4'
39+
- ruby-version: 'jruby-10'
4140
experimental: true
41+
continue-on-error: true
4242
steps:
4343
- uses: actions/checkout@v4
4444
- name: Set up Ruby ${{ matrix.ruby-version }}
@@ -59,16 +59,16 @@ jobs:
5959
fail-fast: false
6060
matrix:
6161
ruby-version:
62-
- '3.1'
6362
- '3.2'
6463
- '3.3'
6564
- '3.4'
6665
experimental: [false]
6766
include:
6867
- ruby-version: 'ruby-head'
6968
experimental: true
70-
- ruby-version: 'jruby-9.4'
69+
- ruby-version: 'jruby-10'
7170
experimental: true
71+
continue-on-error: true
7272
steps:
7373
- uses: actions/checkout@v4
7474
- name: Set up Ruby ${{ matrix.ruby-version }}
@@ -89,16 +89,16 @@ jobs:
8989
fail-fast: false
9090
matrix:
9191
ruby-version:
92-
- '3.1'
9392
- '3.2'
9493
- '3.3'
9594
- '3.4'
9695
experimental: [false]
9796
include:
9897
- ruby-version: 'ruby-head'
9998
experimental: true
100-
- ruby-version: 'jruby-9.4'
99+
- ruby-version: 'jruby-10'
101100
experimental: true
101+
continue-on-error: true
102102
steps:
103103
- uses: actions/checkout@v4
104104
- name: Set up Ruby ${{ matrix.ruby-version }}
@@ -119,16 +119,16 @@ jobs:
119119
fail-fast: false
120120
matrix:
121121
ruby-version:
122-
- '3.1'
123122
- '3.2'
124123
- '3.3'
125124
- '3.4'
126125
experimental: [false]
127126
include:
128127
- ruby-version: 'ruby-head'
129128
experimental: true
130-
- ruby-version: 'jruby-9.4'
129+
- ruby-version: 'jruby-10'
131130
experimental: true
131+
continue-on-error: true
132132

133133
steps:
134134
- uses: actions/checkout@v4

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ AllCops:
1111
- 'tmp/**/*'
1212
- 'vendor/**/*'
1313
- 'gemfiles/*'
14-
TargetRubyVersion: 3.1
14+
TargetRubyVersion: 3.2
1515

1616
Metrics/BlockLength:
1717
Enabled: false

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...main)
22

3+
* [CHANGE] Drop support for Ruby 3.1.x, including moving CI from JRuby 9.4 to JRuby 10 (by [@faisal][])
4+
35
# v4.10.0 / 2025-07-30 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...v4.10.0)
46

57
* [CHANGE] Bump aruba, byebug, cucumber, fakefs, rake, reek dependencies (by [@faisal][])

rubycritic.gemspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@ require 'rubycritic/version'
77
Gem::Specification.new do |spec|
88
spec.name = 'rubycritic'
99
spec.version = RubyCritic::VERSION
10+
spec.platform = RUBY_PLATFORM == 'java' ? Gem::Platform::JAVA : Gem::Platform::RUBY
1011
spec.authors = ['Guilherme Simoes']
1112
spec.email = ['[email protected]']
1213
spec.description = 'RubyCritic is a tool that wraps around various static analysis gems ' \
1314
'to provide a quality report of your Ruby code.'
1415
spec.summary = 'RubyCritic is a Ruby code quality reporter'
1516
spec.homepage = 'https://github.com/whitesmith/rubycritic'
1617
spec.license = 'MIT'
17-
spec.required_ruby_version = '>= 3.1.0'
18+
spec.required_ruby_version = '>= 3.2.0'
1819

1920
spec.files = [
2021
'CHANGELOG.md',
@@ -45,6 +46,7 @@ Gem::Specification.new do |spec|
4546
spec.add_development_dependency 'aruba', '~> 2.3.1', '>= 2.3.1'
4647
spec.add_development_dependency 'bundler', '>= 2.0.0'
4748
if RUBY_PLATFORM == 'java'
49+
spec.add_development_dependency 'jar-dependencies', '~> 0.5.4'
4850
spec.add_development_dependency 'pry-debugger-jruby'
4951
else
5052
spec.add_development_dependency 'byebug', '~> 12.0', '>= 10.0'

0 commit comments

Comments
 (0)