Skip to content

[FOR DISCUSSION] continue-on-error for ruby-head, jruby #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etagwerker merged 3 commits into from
Oct 14, 2025
Merged

[FOR DISCUSSION] continue-on-error for ruby-head, jruby #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e29960a
continue-on-error for ruby-head, jruby
etagwerker Mar 6, 2025
e60c945
force failure in HEAD
faisal Oct 14, 2025
c465fda
movie continue-on-error to step level
faisal Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
needs: pre_job # skip duplicates
if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.experimental }}
strategy:
fail-fast: false
matrix:
Expand All @@ -49,6 +48,7 @@ jobs:
cache-version: 1
- name: Run Cucumber
run: bundle exec cucumber features --format progress --color
continue-on-error: ${{ matrix.experimental }}

Rubocop:
needs: pre_job # skip duplicates
Expand Down
15 changes: 0 additions & 15 deletions features/support/env.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,5 @@
# frozen_string_literal: true

if RUBY_VERSION == '3.5.0' && RUBY_PATCHLEVEL == -1
module Cucumber
module Core
module Test
module Location
singleton_class.send(:alias_method, :original_from_source_location, :from_source_location)
def self.from_source_location(file, start_line, _start_column = nil, _end_line = nil, _end_column = nil)
original_from_source_location(file, start_line)
end
end
end
end
end
end

require_relative '../../lib/rubycritic'
require_relative '../../lib/rubycritic/cli/application'
require_relative '../../lib/rubycritic/commands/status_reporter'
Expand Down
Loading