feat: store unknown messages - WPB-11752 #3431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # wire-ios-data-model/Source/Model/Message/ZMOTRMessage+UpdateEvent.swift # wire-ios-data-model/Source/Utilis/Protos/GenericMessage+Debug.swift
Co-authored-by: zenkins <[email protected]>
…feat/handle-unknown-messages-CA-WPB-11752 # Conflicts: # wire-ios-data-model/Source/Model/Message/ZMOTRMessage+UpdateEvent.swift # wire-ios-data-model/Source/Public/ZMMessage.h # wire-ios-data-model/Source/Utilis/Protos/GenericMessage+Utils.swift # wire-ios-protos/Protos/messages.pb.swift # wire-ios-protos/Protos/mls.pb.swift # wire-ios-protos/Protos/otr.pb.swift # wire-ios/Wire-iOS.xcodeproj/project.pbxproj # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Components/ConversationSystemMessageCellDescription.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Components/UnknownStoredMessageCellDescription.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/ConversationMessageSectionController.swift
…known-messages-CA-WPB-11752
johnxnguyen
approved these changes
Oct 8, 2025
Collaborator
johnxnguyen
left a comment
johnxnguyen
left a comment
There was a problem hiding this comment.
Looks good, nice work
caldrian
requested review from
a team,
jullianm and
samwyndham
and removed request for
a team and
KaterinaWire
samwyndham
approved these changes
Oct 9, 2025
wire-ios-data-model/Source/Model/Message/UnknownMessage/UnknownMessage.swift
Show resolved
Hide resolved
...ent/Cells/ConfigurationMessageCell/Components/ConversationSystemMessageCellDescription.swift
Show resolved
Hide resolved
...Processor/ConversationMessageAddEventProcessor/ConversationMLSMessageAddEventProcessor.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Aldrian <[email protected]>
…0-b5f6081e3a996edf7adec9909c473d396d8122f2' into feat/handle-unknown-messages-CA-WPB-11752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR implements a solution for handling unknown message content types when the protobuf declaration is extended with new message types that the current app version doesn't support.
UnknownMessageentity)UnknownMessageProcessingServicecontains the code to re-process message payloads (copied fromConversationMLSMessageAddEventProcessor) and can be reused by differentAppVersionMigrations.Testing
For testing I extended the content types in the
GenericMessageProtocolrepo and sent a message between two clients.Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: