Merge pull request #14357 from woocommerce/issue/woomob-908-woo-posbarcodes-scanners-might-have-troubles-scanning

[WOOMOB-908] Improve scanning performance in dark mode for Scanner setup flow

Author: malinajirka

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/compose/component/BarcodeComponent.kt

@@ -80,8 +80,8 @@ fun BarcodeEAN13Code(
     content: String,
     widthDp: Dp,
     heightDp: Dp,
-    codeColor: Color,
-    backgroundColor: Color,
+    codeColor: Color = colorResource(id = R.color.woo_black_90),
+    backgroundColor: Color = colorResource(id = R.color.woo_white),
     @DrawableRes overlayId: Int? = null,
 ) {
     Image(

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/common/composeui/component/WooPosBrightnessControl.kt

@@ -0,0 +1,49 @@
+package com.woocommerce.android.ui.woopos.common.composeui.component
+
+import android.app.Activity
+import androidx.compose.runtime.Composable
+import androidx.compose.runtime.DisposableEffect
+import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.getValue
+import androidx.compose.runtime.mutableStateOf
+import androidx.compose.runtime.remember
+import androidx.compose.runtime.setValue
+import androidx.compose.ui.platform.LocalContext
+
+@Composable
+fun WooPosBrightnessControl(temporarilyIncreaseToMax: Boolean = true) {
+    val context = LocalContext.current
+    var originalBrightness by remember { mutableStateOf<Float?>(null) }
+
+    LaunchedEffect(temporarilyIncreaseToMax) {
+        val activity = context as? Activity ?: return@LaunchedEffect
+        val window = activity.window
+
+        if (temporarilyIncreaseToMax) {
+            if (originalBrightness == null) {
+                originalBrightness = window.attributes.screenBrightness
+            }
+            window.attributes = window.attributes.apply {
+                screenBrightness = 1.0f
+            }
+        } else {
+            originalBrightness?.let {
+                window.attributes = window.attributes.apply {
+                    screenBrightness = it
+                }
+                originalBrightness = null
+            }
+        }
+    }
+
+    DisposableEffect(Unit) {
+        onDispose {
+            if (temporarilyIncreaseToMax && originalBrightness != null) {
+                val activity = context as? Activity ?: return@onDispose
+                activity.window.attributes = activity.window.attributes.apply {
+                    screenBrightness = originalBrightness ?: -1.0f
+                }
+            }
+        }
+    }
+}

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/scanningsetup/WooPosScanningSetupDialog.kt

@@ -66,6 +66,7 @@ import com.woocommerce.android.ui.compose.component.BarcodeEAN13Code
 import com.woocommerce.android.ui.compose.component.getText
 import com.woocommerce.android.ui.compose.preview.FontScalePreviews
 import com.woocommerce.android.ui.woopos.common.composeui.WooPosPreview
+import com.woocommerce.android.ui.woopos.common.composeui.component.WooPosBrightnessControl
 import com.woocommerce.android.ui.woopos.common.composeui.component.WooPosButton
 import com.woocommerce.android.ui.woopos.common.composeui.component.WooPosButtonState
 import com.woocommerce.android.ui.woopos.common.composeui.component.WooPosDialogWrapper
@@ -141,6 +142,8 @@ fun WooPosScanningSetupDialog(
             id = R.string.woopos_scanning_setup_dialog_content_description
         )
     ) {
+        WooPosBrightnessControl(temporarilyIncreaseToMax = true)
+
         val state by viewModel.state.collectAsState()
         Column(
             modifier = Modifier
@@ -308,10 +311,10 @@ private fun ScannerModeSetupContent(
 
         Box(
             modifier = Modifier
-                .size(172.dp)
+                .size(184.dp)
                 .clip(RoundedCornerShape(WooPosCornerRadius.Medium.value))
                 .background(Color.White)
-                .padding(WooPosSpacing.Small.value.toAdaptivePadding()),
+                .padding(WooPosSpacing.Medium.value.toAdaptivePadding()),
             contentAlignment = Alignment.Center
         ) {
             Image(
@@ -366,13 +369,20 @@ private fun TestScannerContent(
             modifier = Modifier.padding(bottom = WooPosSpacing.Large.value.toAdaptivePadding())
         )
 
-        BarcodeEAN13Code(
-            barcodeValue,
-            300.dp,
-            150.dp,
-            codeColor = MaterialTheme.colorScheme.onSurface,
-            backgroundColor = MaterialTheme.colorScheme.surfaceBright
-        )
+        Box(
+            modifier = Modifier
+                .size(300.dp, 150.dp)
+                .clip(RoundedCornerShape(WooPosCornerRadius.Medium.value))
+                .background(Color.White)
+                .padding(WooPosSpacing.Medium.value.toAdaptivePadding()),
+            contentAlignment = Alignment.Center
+        ) {
+            BarcodeEAN13Code(
+                barcodeValue,
+                300.dp,
+                150.dp
+            )
+        }
 
         Spacer(modifier = Modifier.height(WooPosSpacing.XLarge.value.toAdaptivePadding()))
 
@@ -862,3 +872,44 @@ fun WooPosScanningSetupTestScannerFailedStep() {
         }
     }
 }
+
+@WooPosPreview
+@Composable
+fun WooPosScanningSetupTestQRContent() {
+    WooPosTheme {
+        Box(
+            modifier = Modifier.fillMaxSize(),
+            contentAlignment = Alignment.Center
+        ) {
+            ScannerModeSetupContent(
+                onPrimaryClick = {},
+                onSecondaryClick = {},
+                primaryButtonText = "Next",
+                secondaryButtonText = "Back",
+                title = "Scanner Mode Setup",
+                message = "Follow the instructions to set up your scanner in HID mode.",
+                qrCodeImageRes = R.drawable.ic_woopos_reader_setup_code_star_bsh_20
+            )
+        }
+    }
+}
+
+@WooPosPreview
+@Composable
+fun WooPosScanningSetupTestBarcodeContent() {
+    WooPosTheme {
+        Box(
+            modifier = Modifier.fillMaxSize(),
+            contentAlignment = Alignment.Center
+        ) {
+            TestScannerContent(
+                onSecondaryClick = {},
+                secondaryButtonText = "Back",
+                title = "Scanner Mode Setup",
+                message = "Follow the instructions to set up your scanner in HID mode.",
+                barcodeValue = "123456789012",
+                onBarcodeScanned = {},
+            )
+        }
+    }
+}