Deprecating additional metas from the helper class

Author: wjrosa

includes/class-wc-stripe-helper.php

@@ -12,12 +12,28 @@
  * @since 4.0.0
  */
 class WC_Stripe_Helper {
-	const SETTINGS_OPTION              = 'woocommerce_stripe_settings';
-	const LEGACY_META_NAME_FEE         = 'Stripe Fee';
-	const LEGACY_META_NAME_NET         = 'Net Revenue From Stripe';
-	const META_NAME_STRIPE_CURRENCY    = '_stripe_currency';
+	const SETTINGS_OPTION      = 'woocommerce_stripe_settings';
+	const LEGACY_META_NAME_FEE = 'Stripe Fee';
+	const LEGACY_META_NAME_NET = 'Net Revenue From Stripe';
+
+	/**
+	 * Meta key for the Stripe awaiting action identifier.
+	 *
+	 * @var string
+	 *
+	 * @deprecated 9.5.0 Use WC_Stripe_Order_Metas::PAYMENT_AWAITING_ACTION_META instead.
+	 */
 	const PAYMENT_AWAITING_ACTION_META = '_stripe_payment_awaiting_action';
 
+	/**
+	 * Meta key for the Stripe currency.
+	 *
+	 * @var string
+	 *
+	 * @deprecated 9.5.0 Use WC_Stripe_Order_Metas::META_STRIPE_CURRENCY instead.
+	 */
+	const META_NAME_STRIPE_CURRENCY = '_stripe_currency';
+
 	/**
 	 * The identifier for the official Affirm gateway plugin.
 	 *
@@ -102,7 +118,7 @@ public static function get_stripe_currency( $order = null ) {
 			return false;
 		}
 
-		return $order->get_meta( self::META_NAME_STRIPE_CURRENCY, true );
+		return $order->get_meta( WC_Stripe_Order_Metas::META_STRIPE_CURRENCY, true );
 	}
 
 	/**
@@ -117,7 +133,7 @@ public static function update_stripe_currency( $order, $currency ) {
 			return false;
 		}
 
-		$order->update_meta_data( self::META_NAME_STRIPE_CURRENCY, $currency );
+		$order->update_meta_data( WC_Stripe_Order_Metas::META_STRIPE_CURRENCY, $currency );
 	}
 
 	/**
@@ -1455,7 +1471,7 @@ public static function get_stripe_gateway_ids() {
 	 * @return void
 	 */
 	public static function set_payment_awaiting_action( $order, $save = true ) {
-		$order->update_meta_data( self::PAYMENT_AWAITING_ACTION_META, wc_bool_to_string( true ) );
+		$order->update_meta_data( WC_Stripe_Order_Metas::META_STRIPE_PAYMENT_AWAITING_ACTION, wc_bool_to_string( true ) );
 
 		if ( $save ) {
 			$order->save();
@@ -1471,7 +1487,7 @@ public static function set_payment_awaiting_action( $order, $save = true ) {
 	 * @return void
 	 */
 	public static function remove_payment_awaiting_action( $order, $save = true ) {
-		$order->delete_meta_data( self::PAYMENT_AWAITING_ACTION_META );
+		$order->delete_meta_data( WC_Stripe_Order_Metas::META_STRIPE_PAYMENT_AWAITING_ACTION );
 
 		if ( $save ) {
 			$order->save();

includes/class-wc-stripe-order-handler.php

@@ -476,7 +476,7 @@ public function prevent_cancelling_orders_awaiting_action( $cancel_order, $order
 		}
 
 		// If the order is awaiting action and was modified within the last day, don't cancel it.
-		if ( wc_string_to_bool( $order->get_meta( WC_Stripe_Helper::PAYMENT_AWAITING_ACTION_META, true ) ) && $order->get_date_modified( 'edit' )->getTimestamp() > strtotime( '-1 day' ) ) {
+		if ( wc_string_to_bool( $order->get_meta( WC_Stripe_Order_Metas::META_STRIPE_PAYMENT_AWAITING_ACTION, true ) ) && $order->get_date_modified( 'edit' )->getTimestamp() > strtotime( '-1 day' ) ) {
 			$cancel_order = false;
 		}