Block UI during onApprove callback (4712)

[hmouhtar]

When returning from AppSwitch, the onApprove callback takes a few seconds to finish processing. During this time, the user could click the PayPal button again or trigger other WooCommerce actions like "Proceed to Checkout", which disrupted the AppSwitch flow and caused unexpected issues reported by QA.

This PR addresses the problem by implementing the same approach used at checkout: blocking the entire UI while the payment is being processed.

Classic contexts:

To address this in classic contexts, I've reused the Spinner class, triggering a full-page blocking overlay when the onApprove callback is triggered, and removing it in the .finally callback.

Block contexts:

Block contexts are trickier. Unblocking the spinner in the .finally callback of the onApprove method was too soon, since WooCommerce has its own async order processing in block contexts. This left a significant time window in which the user could perform actions like clicking "Proceed to Checkout".

To handle block contexts, I’ve set up a useEffect that tracks the value of isFullPageSpinnerActive and toggles the spinner when it changes. This allows the spinner to be enabled in the onApprove callback, remain active, and be removed only in exceptional circumstances such as checkout errors which are handled by WooCommerce events.

[Narek13]

LGTM. Thanks for working on this.

[github-actions]

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

🔗 Test this pull request with WordPress Playground

What's included:

• ✅ WordPress (latest)
• ✅ WooCommerce (latest)
• ✅ PayPal Payments plugin v3.0.9-pr3533-17446459823-gb267836 (built from this PR)

Login credentials:

• Username: admin
• Password: password

Plugin Details:

• Version: 3.0.9-pr3533-17446459823-gb267836
• Commit: b267836
• Artifact: woocommerce-paypal-payments-3.0.9-pr3533-17446459823-gb267836

💡 The demo environment resets each time you refresh. Perfect for testing!

🔄 This link updates automatically with each new commit to the PR.

⚠️ This URL is valid for 30 days from when this comment was last updated.

---

_{🤖 Auto-generated for commit b267836 • Last updated: 2025-09-03T21:29:56.465Z}

[Narek13]

Thanks for working on this. LGTM