Change editorSettings to a String

The host app doesn’t need to parse it, so we can pass the raw settings

Author: jkmassel

ios/Sources/GutenbergKit/Sources/EditorConfiguration.swift

@@ -27,7 +27,7 @@ public struct EditorConfiguration {
     /// Authorization header
     public let authHeader: String
     /// Raw block editor settings from the WordPress REST API
-    public let editorSettings: EditorSettings
+    public let editorSettings: String
     /// Locale used for translations
     public let locale: String
     /// Endpoint for loading editor assets, used when enabling `shouldUsePlugins`
@@ -50,7 +50,7 @@ public struct EditorConfiguration {
         siteApiNamespace: [String],
         namespaceExcludedPaths: [String],
         authHeader: String,
-        editorSettings: EditorSettings,
+        editorSettings: String,
         locale: String,
         editorAssetsEndpoint: URL? = nil,
         cookies: [HTTPCookie] = []
@@ -101,12 +101,6 @@ public struct EditorConfiguration {
         content.addingPercentEncoding(withAllowedCharacters: .alphanumerics)!
     }
 
-    var editorSettingsJSON: String {
-        // `editorSettings` values are always `encodable` so this should never fail
-        let jsonData = try! JSONSerialization.data(withJSONObject: editorSettings, options: [])
-        return String(data: jsonData, encoding: .utf8) ?? "undefined"
-    }
-
     public static let `default` = EditorConfigurationBuilder().build()
 }
 
@@ -123,7 +117,7 @@ public struct EditorConfigurationBuilder {
     private var siteApiNamespace: [String]
     private var namespaceExcludedPaths: [String]
     private var authHeader: String
-    private var editorSettings: EditorSettings
+    private var editorSettings: String
     private var locale: String
     private var editorAssetsEndpoint: URL?
 
@@ -140,7 +134,7 @@ public struct EditorConfigurationBuilder {
         siteApiNamespace: [String] = [],
         namespaceExcludedPaths: [String] = [],
         authHeader: String = "",
-        editorSettings: EditorSettings = [:],
+        editorSettings: String = "undefined",
         locale: String = "en",
         editorAssetsEndpoint: URL? = nil
     ){
@@ -233,7 +227,7 @@ public struct EditorConfigurationBuilder {
         return copy
     }
 
-    public func setEditorSettings(_ editorSettings: EditorSettings) -> EditorConfigurationBuilder {
+    public func setEditorSettings(_ editorSettings: String) -> EditorConfigurationBuilder {
         var copy = self
         copy.editorSettings = editorSettings
         return copy

ios/Sources/GutenbergKit/Sources/EditorViewController.swift

@@ -146,13 +146,7 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
 
     private func getEditorConfiguration() -> WKUserScript {
 
-        // Generate JavaScript globals
-        let globalsJS = configuration.webViewGlobals.map { global in
-            "window[\"\(global.name)\"] = \(global.value.toJavaScript());"
-        }.joined(separator: "\n")
-
         let jsCode = """
-        \(globalsJS)
 
         window.GBKit = {
             siteURL: '\(configuration.siteURL)',
@@ -162,7 +156,7 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
             authHeader: '\(configuration.authHeader)',
             themeStyles: \(configuration.shouldUseThemeStyles),
             hideTitle: \(configuration.shouldHideTitle),
-            editorSettings: \(configuration.editorSettingsJSON),
+            editorSettings: \(configuration.editorSettings),
             locale: '\(configuration.locale)',
             post: {
                 id: \(configuration.postID ?? -1),