Refactor tests to use matrix-based approach for all WordPress hook functions

Author: johnbillion

src/test/suite/callbackCompletion.test.ts

@@ -2,99 +2,64 @@ import * as assert from 'assert';
 import * as vscode from 'vscode';
 
 suite('Callback Completion Test Suite', () => {
-	test('Should provide callback completions for add_action', async () => {
-		const doc = await vscode.workspace.openTextDocument({
-			language: 'php',
-			content: "<?php\nadd_action('init', ",
+	// Only add_action and add_filter support callbacks
+	const callbackFunctions = [
+		{ fn: 'add_action', hook: 'init' },
+		{ fn: 'add_filter', hook: 'the_content' },
+	];
+
+	const commonCallbackTypes = [
+		{ label: 'Closure' },
+		{ label: 'Function' },
+	];
+
+	const filterSpecificTypes = [
+		{ label: 'Arrow' },
+	];
+
+	callbackFunctions.forEach(({ fn, hook }) => {
+		const isFilter = fn.includes('filter');
+
+		test(`Should provide callback completions for ${fn}`, async () => {
+			const doc = await vscode.workspace.openTextDocument({
+				language: 'php',
+				content: `<?php\n${fn}('${hook}', `,
+			});
+
+			await vscode.window.showTextDocument(doc);
+			await new Promise((resolve) => setTimeout(resolve, 100));
+
+			const pos = fn.length + hook.length + 7;
+			const position = new vscode.Position(1, pos);
+
+			const completions = await vscode.commands.executeCommand<vscode.CompletionList>(
+				'vscode.executeCompletionItemProvider',
+				doc.uri,
+				position,
+			);
+
+			assert.ok(completions, 'Completions should be returned');
+			assert.ok(completions.items.length > 0, 'Should have completion items');
+
+			const labels = completions.items.map((item) => (typeof item.label === 'string' ? item.label : item.label.label));
+
+			// Test common callback types
+			commonCallbackTypes.forEach(({ label }) => {
+				assert.ok(
+					labels.some((l) => l === label || l.includes(label)),
+					`Should include ${label} option for ${fn}`,
+				);
+			});
+
+			// Test filter-specific types
+			if (isFilter) {
+				filterSpecificTypes.forEach(({ label }) => {
+					assert.ok(
+						labels.some((l) => l === label || l.includes(label)),
+						`Should include ${label} option for ${fn}`,
+					);
+				});
+			}
 		});
-
-		await vscode.window.showTextDocument(doc);
-		await new Promise((resolve) => setTimeout(resolve, 100));
-
-		const position = new vscode.Position(1, 20);
-
-		const completions = await vscode.commands.executeCommand<vscode.CompletionList>(
-			'vscode.executeCompletionItemProvider',
-			doc.uri,
-			position,
-		);
-
-		assert.ok(completions, 'Completions should be returned');
-		assert.ok(completions.items.length > 0, 'Should have completion items');
-
-		const labels = completions.items.map((item) => (typeof item.label === 'string' ? item.label : item.label.label));
-
-		// Should have standard callback types
-		assert.ok(
-			labels.some((label) => label === 'Closure' || label.includes('Closure')),
-			'Should include Closure option',
-		);
-		assert.ok(
-			labels.some((label) => label === 'Function' || label.includes('Function')),
-			'Should include Function option',
-		);
-	});
-
-	test('Should provide callback completions for add_filter', async () => {
-		const doc = await vscode.workspace.openTextDocument({
-			language: 'php',
-			content: "<?php\nadd_filter('the_content', ",
-		});
-
-		await vscode.window.showTextDocument(doc);
-		await new Promise((resolve) => setTimeout(resolve, 100));
-
-		const position = new vscode.Position(1, 32);
-
-		const completions = await vscode.commands.executeCommand<vscode.CompletionList>(
-			'vscode.executeCompletionItemProvider',
-			doc.uri,
-			position,
-		);
-
-		assert.ok(completions, 'Completions should be returned');
-		assert.ok(completions.items.length > 0, 'Should have completion items');
-
-		const labels = completions.items.map((item) => (typeof item.label === 'string' ? item.label : item.label.label));
-
-		// Should have callback types including arrow function for filters
-		assert.ok(
-			labels.some((label) => label === 'Arrow function' || label.includes('Arrow')),
-			'Should include Arrow function option for filters',
-		);
-	});
-
-	test('Should include WordPress utility functions for filters', async () => {
-		const doc = await vscode.workspace.openTextDocument({
-			language: 'php',
-			content: "<?php\nadd_filter('the_content', ",
-		});
-
-		await vscode.window.showTextDocument(doc);
-		await new Promise((resolve) => setTimeout(resolve, 100));
-
-		const position = new vscode.Position(1, 32);
-
-		const completions = await vscode.commands.executeCommand<vscode.CompletionList>(
-			'vscode.executeCompletionItemProvider',
-			doc.uri,
-			position,
-		);
-
-		assert.ok(completions, 'Completions should be returned');
-		const labels = completions.items.map((item) => (typeof item.label === 'string' ? item.label : item.label.label));
-
-		// Check for WordPress utility functions
-		const hasUtilityFunctions = labels.some((label) => label && (
-				label.includes('Return true')
-				|| label.includes('Return false')
-				|| label.includes('Return null')
-				|| label.includes('return')
-			));
-
-		assert.ok(
-			hasUtilityFunctions,
-			`Should include WordPress utility function options. Got: ${labels.slice(0, 15).join(', ')}`,
-		);
 	});
 });