Skip to content

Updating the CDS Favorites module #1922

@FelicianoTech

Description

@FelicianoTech

To power the WTF CDS->Favorites module, we use the official Go module from OVH: github.com/ovh/cds

There's an update to the module that Dependabot is suggesting we update to however the PR is failing CI tests. The reason is because OVH has made a backwards incompatible change.

Now I don't use CDS (never have) so I'm doing my best here to understand that project, how WTF works with it, and why this update has broken things. Here's my understanding of the change. If anyone can confirm or deny, I would appreciate it.

It seems that CDS have changed some of their concepts in their UI. "Favorites", which is what this module is for, doesn't seem to be a thing anymore. Instead, it seems that they have moved to the concept of "bookmarks" now.

That being said, I'm trying to figure out the best way to handle this:

  1. My first inclination is to just pull the new concept of bookmarks in the code, leave the module name the same, and publish that. This will potentially break people running older versions of CDS that still use "favorites" but will then work with newer versions.
  2. Another option is to create a new CDS->Bookmarks module. The problem is, since OVH did not follow SemVer, I can't use the old CDS Go module and new one at the same time. Instead, a clone would need to be made. This is a lot of extra work.
  3. I can just drop the CDS->Favorites module and avoid the problem all together.

Are any of you actually using this module? That information would help inform what to do here. In the meantime, I'll likely work on a PR following solution no. 1.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions