fix(linstorvolumemanager): don't allow InUse volumes to be deleted

Check for usage status before deleting a linstor volume and raise an appropriate error if this happens

Signed-off-by: Antoine Bartuccio <[email protected]>

Author: klmp200

drivers/linstorvolumemanager.py

@@ -15,7 +15,7 @@
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 #
 
-from sm_typing import override
+from sm_typing import Dict, override
 
 import errno
 import json
@@ -682,9 +682,28 @@ def destroy_volume(self, volume_uuid):
         Destroy a volume.
         :param str volume_uuid: The volume uuid to destroy.
         """
+        def get_volume_info(volume_uuid: str) -> Dict:
+            for volume in self.get_resources_info().values():
+                if volume["uuid"] == volume_uuid:
+                    return volume
+            raise LinstorVolumeManagerError(
+                f"Could not find info about volume `{volume_uuid}`",
+                LinstorVolumeManagerError.ERR_VOLUME_DESTROY
+            )
+
+        def is_volume_in_use(volume_info: Dict) -> bool:
+            for node in volume_info["nodes"].values():
+                if node["in-use"]:
+                    return True
+            return False
 
         self._ensure_volume_exists(volume_uuid)
         self.ensure_volume_is_not_locked(volume_uuid)
+        if is_volume_in_use(get_volume_info(volume_uuid)):
+            raise LinstorVolumeManagerError(
+                f"Could not destroy volume `{volume_uuid}` as it is currently in use",
+                LinstorVolumeManagerError.ERR_VOLUME_DESTROY
+            )
 
         # Mark volume as destroyed.
         volume_properties = self._get_volume_properties(volume_uuid)