Merge pull request #366 from xcp-ng/dtt-xostor-new-disks

xostor.md: add separate section for adding disks

Author: stormi

docs/xostor/xostor.md

@@ -659,14 +659,23 @@ xe host-call-plugin host-uuid=<HOST_UUID> plugin=linstor-manager fn=addHost args
 ```
 For a short description, this command (re)creates a PBD, opens DRBD/LINSTOR ports, starts specific services and adds the node to the LINSTOR database.
 
-If you have storage devices to use on the host, a LINSTOR storage layer is not directly added to the corresponding node. You can verify the storage state like this:
+If you have storage devices to use on the host, a LINSTOR storage layer is not directly added to the corresponding node.
+You can follow the [section](#how-to-add-storage-on-a-new-host) below to add storage to this new node.
+
+### How to add storage on a new host?
+
+There are two simple steps:
+1. Create a VG (and LV for thin) with all the host disks
+2. Create a SP for the host pointing to this new VG
+
+You can verify the storage state like this:
 ```
 linstor sp list
 ```
 
 Small example:
 
-A `LVM_THIN` entry is missing for `hpmc17` in this context:
+A `LVM_THIN` entry is missing for `hpmc17` in this context, meaning it has no local storage:
 ```
 ╭──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
 ┊ StoragePool                      ┊ Node   ┊ Driver   ┊ PoolName                  ┊ FreeCapacity ┊ TotalCapacity ┊ CanSnapshots ┊ State ┊ SharedName                              ┊
@@ -679,13 +688,15 @@ A `LVM_THIN` entry is missing for `hpmc17` in this context:
 ╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
 ```
 
-So if your host has disks that need to be added to the linstor SR, you will need to create VG/LV.
+1. Creating a LVM volume group and/or thin device
+
+To add disks to the linstor SR, you will need to create a LVM volume group.
 Connect to the machine to modify and use `vgcreate` with the wanted disks to create a VG group on the host:
 ```
 vgcreate <GROUP_NAME> <DEVICES>
 ```
 
-In this example where we want to use /dev/nvme0n1 with the group `linstor_group`:
+In our example where we want to use `/dev/nvme0n1` with the group `linstor_group`:
 ```
 vgcreate linstor_group /dev/nvme0n1
 ```
@@ -696,20 +707,23 @@ lvcreate -l 100%FREE -T <GROUP_NAME>/<LV_THIN_VOLUME>
 lvchange -ay <GROUP_NAME>/<LV_THIN_VOLUME>
 ```
 
-Always regarding this example, we have:
-- `<HOSTNAME>`: `linstor_group`.
+Most of the time and in our example, we will have:
+- `<GROUP_NAME>`: `linstor_group`.
 - `<LV_THIN_VOLUME>`: `thin_device`.
+- `<SP_NAME>`: `xcp-sr-linstor_group_thin_device`.
+
+2. Create a new storage pool attached to the node
 
-Run the correct command where the controller is running to add the volume group in the LINSTOR database:
+Run the corresponding command on the host where the controller is running to add the volume group in the LINSTOR database:
 ```
 # For thin:
-linstor storage-pool create lvmthin <NODE_NAME> <SP_NAME> <VG_NAME>
+linstor storage-pool create lvmthin <NODE_NAME> <SP_NAME> <VG_NAME>/<LV_THIN_VOLUME>
 
 # For thick:
 linstor storage-pool create lvm <NODE_NAME> <SP_NAME> <VG_NAME>
 ```
 
-In this example:
+In our example:
 ```
 linstor storage-pool create lvm hpmc17 xcp-sr-linstor_group_thin_device linstor_group/thin_device
 ```